Increase the chance of local and remote part communicate in multinode test#1914
Merged
Merged
Conversation
… test In one of the failing test executions I noticed sometimes the remote part starts a bit later, probably because the CI machine is overloaded or libraries take long time to load. In that specific case, there was only one message with MOs which could have been received, but it was sent together with EndOfStream. The remote part received this EndOfStream, but did not receive the message with MOs, maybe one got there faster than the other... While this is something which could be fixed at the level of passing data around, I do not assume this is reliable at this stage anyway. Two mitigations are put in place: - producer runs 5s longer (5 more messages), there is less chance that the only MonitorObjectCollection that proxy and Merger receive is sent during EOS - the remote workflow part is started first, so it's less likely that a MonitorObjectCOllection is published before the proxy and Merger start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one of the failing test executions I noticed sometimes the remote part starts a bit later, probably because the CI machine is overloaded or libraries take long time to load. In that specific case, there was only one message with MOs which could have been received, but it was sent together with EndOfStream. The remote part received this EndOfStream, but did not receive the message with MOs, maybe one got there faster than the other... While this is something which could be fixed at the level of passing data around, I do not assume this is reliable at this stage anyway.
Two mitigations are put in place: