[FDD] Fill BC vs FEE module plots channel wise#1975
Merged
Conversation
afurs
reviewed
Sep 7, 2023
Collaborator
|
@afurs has some valid refactoring points that should be implemented at some point. However, doing so requires more time and testing, and since we need this asap, I'd vote for going with this at the moment, as it is tested and ready. It is also tested in the sense that it is the same as the already running version of FV0. But if you have time @arvindkhuntia, feel free to implement according to Arturs comments. |
andreasmolander
approved these changes
Sep 7, 2023
Collaborator
|
If we need to have this modifications ASAP - then of course no problem. But code reading becomes more complicated |
Barthelemy
approved these changes
Sep 12, 2023
Barthelemy
pushed a commit
that referenced
this pull request
Sep 18, 2023
* [FDD] Fill BC vs FEE module plots channel wise * [FDD] Clang format --------- Co-authored-by: Arvind Khuntia <arvind.khuntia@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @andreasmolander , @afurs, please have a look.