[QC-858] Single CheckRunner per workflow#2028
Merged
Barthelemy merged 14 commits intoNov 30, 2023
Merged
Conversation
Barthelemy
changed the title
knopers8
approved these changes
Nov 15, 2023
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thanks, it seems correct.
I am slightly worried if it is going to work well with async workflows, where we have one big workflow with all of the tasks/checks. If you have access to alien, perhaps you could run it with this input file and --remote-batch option:
/alice/data/2023/LHC23zp/539421/apass1/0940/QC/001/QC.root`
this config file (but ccdb-test)
/alice/data/2023/LHC23zp/539421/apass1/0940/QC/001/QC_production.json
Co-authored-by: Piotr Konopka <piotr.jan.konopka@cern.ch>
Co-authored-by: Piotr Konopka <piotr.jan.konopka@cern.ch>
Collaborator
Author
|
Good point about async. Not sure how to run what you propose but it is an opportunity to learn. I'll let you know the result. |
Collaborator
Author
|
I tested with run 544124. I found 1 bug that I fixed (disabled checks were included). It worked. |
Barthelemy
added a commit
to Barthelemy/QualityControl
that referenced
this pull request
Dec 1, 2023
This reverts commit 488c547.
Barthelemy
added a commit
that referenced
this pull request
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.