[EMCAL-1119] added 6 checkers for the EMC Calibration runs#2241
Merged
jokonig merged 6 commits intoAliceO2Group:masterfrom Apr 19, 2024
Merged
[EMCAL-1119] added 6 checkers for the EMC Calibration runs#2241jokonig merged 6 commits intoAliceO2Group:masterfrom
jokonig merged 6 commits intoAliceO2Group:masterfrom
Conversation
added 2 commits
April 16, 2024 15:47
6 checkers Number of Good/Dead/Bad Channels in EMCAL + DCAL Time Calib Coeff Fraction of good cells / event Fraction of good cells / supermodule Cell amplitude (Calib) vs. supermodule ID PHYS Cell Time (Calib) vs. supermodule ID (High gain) PHYS
sweyh99
requested review from
Barthelemy,
jokonig,
knopers8 and
mfasDa
as code owners
jokonig
reviewed
Apr 17, 2024
|
|
||
| Float_t avg_frac = 0.0; | ||
| for (int i=1; i<=h_det->GetNbinsX(); i++){ | ||
| Float_t weight = h_det->GetBinContent(i)*h_det->GetBinCenter(i); |
Collaborator
There was a problem hiding this comment.
this line is not needed I think. "weight" is never used
|
|
||
| Float_t avg_frac = 0.0; | ||
| for (int i=1; i<=h_supermod->GetNbinsX(); i++){ | ||
| Float_t weight = h_supermod->GetBinContent(i)*h_supermod->GetBinCenter(i); |
| else { | ||
| h_supermod->Scale(1.0/h_supermod->Integral()); | ||
|
|
||
| Double_t chi2_SM = -1000; |
Collaborator
There was a problem hiding this comment.
I think this line is not needed, just define it in the next line?
| } | ||
| else { | ||
| Double_t mean_allsupermod = h_allsupermod_proj->GetMean(); | ||
| if (mean_allsupermod > mBadThresholdCellTimeSupermoduleCalibPHYS) { |
Collaborator
There was a problem hiding this comment.
Shouldn't we also have a lower bound here? The mean can also be shifted to lower times compared to what we expect
Contributor
Author
There was a problem hiding this comment.
Yes you're right. I have changed it so the absolute value is within some threshold of 0
| if (mean_allsupermod > mBadThresholdCellTimeSupermoduleCalibPHYS) { | ||
| result = Quality::Bad; | ||
| } | ||
| else if (mean_allsupermod > mMedThresholdCellTimeSupermoduleCalibPHYS) { |
| } | ||
| else { | ||
| Double_t mean_isupermod = h_supermod->GetMean(); | ||
| if (mean_isupermod > mBadThresholdCellTimeSupermoduleCalibPHYS) { |
| result = Quality::Bad; | ||
| break; | ||
| } | ||
| else if (mean_isupermod > mMedThresholdCellTimeSupermoduleCalibPHYS) { |
added 3 commits
April 17, 2024 08:05
Remove unnecessary weight and chi2 lines and add lower bound for Cell Time (Calib) vs. supermodule ID (High gain) PHYS
…into EMCAL-1119
jokonig
approved these changes
Apr 19, 2024
anabananana98
pushed a commit
to anabananana98/QualityControlEMC
that referenced
this pull request
Apr 23, 2024
…oup#2241) * o2 [EMCAL-1119] added 6 checkers for the EMC Calibration runs 6 checkers - Number of Good/Dead/Bad Channels in EMCAL + DCAL - Time Calib Coeff - Fraction of good cells / event - Fraction of good cells / supermodule - Cell amplitude (Calib) vs. supermodule ID PHYS - Cell Time (Calib) vs. supermodule ID (High gain) PHYS --------- Co-authored-by: Sierra Weyhmiller <sierra.lisa.weyhmiller@cern.ch>
anabananana98
pushed a commit
to anabananana98/QualityControlEMC
that referenced
this pull request
Apr 24, 2024
…oup#2241) * o2 [EMCAL-1119] added 6 checkers for the EMC Calibration runs 6 checkers - Number of Good/Dead/Bad Channels in EMCAL + DCAL - Time Calib Coeff - Fraction of good cells / event - Fraction of good cells / supermodule - Cell amplitude (Calib) vs. supermodule ID PHYS - Cell Time (Calib) vs. supermodule ID (High gain) PHYS --------- Co-authored-by: Sierra Weyhmiller <sierra.lisa.weyhmiller@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6 checkers
Number of Good/Dead/Bad Channels in EMCAL + DCAL
Time Calib Coeff
Fraction of good cells / event
Fraction of good cells / supermodule
Cell amplitude (Calib) vs. supermodule ID PHYS
Cell Time (Calib) vs. supermodule ID (High gain) PHYS