[QC-1079] Run type as a string (new attempt...)#2282
Merged
Barthelemy merged 3 commits intoMay 8, 2024
Conversation
* [QC-1079] run type as string * doc * config files * format * clearer method name * 1. extract isOnlyDigits to stringUtils 2. handle the case when the run type is a number and convert it to the string representation 3. tests * fix broken test * Test the translation of an integer run type into a string run type. Also warn the user of the translation. * format * forgot the test * fix (one line went missing0 * format * rebase master unify isOnlyDigits and is_unsigned_integer into isUnsignedInteger
Barthelemy
requested review from
IsakovAD,
afurs,
andreasmolander,
iravasen,
jokonig,
justonedev1,
knopers8,
mfasDa,
njacazio and
wiechula
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.