Skip to content

QC-1178 window length should be infinite if moving windows are not used #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
May 27, 2024
Merged

QC-1178 window length should be infinite if moving windows are not used #2302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Framework/src/TaskRunner.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ void TaskRunner::init(InitContext& iCtx)

// setup timekeeping
mDeploymentMode = DefaultsHelpers::deploymentMode();
mTimekeeper = TimekeeperFactory::create(mDeploymentMode, mTaskConfig.cycleDurations.back().first * 1000);
Copy link
Copy Markdown
Member

@ktf ktf May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you guaranteed that mTaskConfig.cycleDurations is not empty?

Copy link
Copy Markdown
Collaborator Author

@knopers8 knopers8 May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, something would have to go very wrong. The configuration goes through TaskRunnerFactory which does the input sanitization.

auto windowLengthMs = mTaskConfig.movingWindows.empty() ? 0 : (mTaskConfig.cycleDurations.back().first * 1000);
mTimekeeper = TimekeeperFactory::create(mDeploymentMode, windowLengthMs);
mTimekeeper->setCCDBOrbitsPerTFAccessor([]() {
// getNHBFPerTF() returns 128 if it does not know, which can be very misleading.
// instead we use 0, which will trigger another try when processing another timeslice.
Expand Down