Skip to content

Add a few safeguards to o2-qc-repo-update-run-type #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Jun 4, 2024
Merged

Add a few safeguards to o2-qc-repo-update-run-type #2318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Framework/script/RepoCleaner/qcrepocleaner/o2-qc-repo-update-run-type
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def run(args):
logging.fatal(f"Could not find columns `runNumber` and `runType` in {args.runs_file}, make sure the column headers are correct.")
exit(1)

if run_type == "null":
if run_type == "null" or run_type == "":
logging.debug(f"Skipping run {run_number} because its type is `null`")
continue
logging.debug(f"Run : {run_number} -> {run_type}")
Expand All @@ -65,13 +65,21 @@ def run(args):
logging.info(f"Number of versions found: {len(versions)}")
total_planned += len(versions)
for version in versions:
if "RunNumber" not in version.metadata:
logging.debug(f"{version} misses metadata RunNumber")
continue
run_number = version.metadata["RunNumber"]
if version.metadata["RunNumber"] not in mapping_run_types:
logging.debug(f"No mapping run {version.metadata['RunNumber']}")
logging.debug(f"{version} : No mapping for run {version.metadata['RunNumber']}")
continue

run_type = mapping_run_types[run_number]
logging.info(f"Ready to update {version} : \"{version.metadata['RunType']}\" -> \"{run_type}\"")
old_run_type = version.metadata['RunType'] if 'RunType' in version.metadata else "null"
if old_run_type != run_type:
logging.info(f"Ready to update {version} : \"{old_run_type}\" -> \"{run_type}\"")
else:
logging.info(f"Won't update {version} : run type is already {run_type}")
continue

if args.print_list:
continue
Expand Down