[QC-1227] Get beam type from PDP parameter#2461
Merged
Merged
Conversation
justonedev1
reviewed
Oct 28, 2024
Collaborator
justonedev1
left a comment
justonedev1
left a comment
There was a problem hiding this comment.
Are the string values from pdp_beam_type defined somewhere? I saw them mentioned by Andrea but without any link
Collaborator
Author
|
short answer: I don't know. |
Member
|
No idea. @shahor02 maybe? |
Contributor
|
|
Collaborator
Author
|
Ok, thank you for the info. I conclude that the format of these values is defined somewhere in ODC. |
justonedev1
reviewed
Oct 28, 2024
| } else if (pdpBeamType == "pPb") { | ||
| return "Pb-PROTON"; | ||
| } else { | ||
| return ""; |
Collaborator
There was a problem hiding this comment.
Maybe add some warning, that we met value that we did not expect?
Collaborator
Author
There was a problem hiding this comment.
done, I let you have a look
Warn if we can't convert
justonedev1
approved these changes
Oct 28, 2024
Barthelemy
added a commit
that referenced
this pull request
Oct 29, 2024
* [QC-1227] Get beam type from PDP parameter * remove useless line * Update runnerUtils.cxx Warn if we can't convert * Update runnerUtils.cxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.