Fix CompletionPolicy for BookkeepingQualitySink #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A label for matching the correct CompletionPolicy in BookkeepingQualitySink was missing. This was causing it to wait indefinitely for matching inputs for the same timeslice if QOs from different Data Processors were requested. The change allows BookkeepingQualitySink to consume the inputs immediatelly and pass them to any other process which may also need them.
Collaborator
Author
|
The command below with the provided configuration file reproduces the issue observed by Robert. With this fix, the reproducer behaves OK. |
Barthelemy
approved these changes
Oct 30, 2024
Barthelemy
pushed a commit
that referenced
this pull request
Oct 31, 2024
A label for matching the correct CompletionPolicy in BookkeepingQualitySink was missing. This was causing it to wait indefinitely for matching inputs for the same timeslice if QOs from different Data Processors were requested. The change allows BookkeepingQualitySink to consume the inputs immediatelly and pass them to any other process which may also need them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A label for matching the correct CompletionPolicy in BookkeepingQualitySink was missing. This was causing it to wait indefinitely for matching inputs for the same timeslice if QOs from different Data Processors were requested. The change allows BookkeepingQualitySink to consume the inputs immediatelly and pass them to any other process which may also need them.