[EMCAL-646] Adapt QualityControl to changes in EMCAL raw parsing#456
Merged
Conversation
Collaborator
Author
|
Adapting QualityControl to changes in AliceO2Group/AliceO2#4128. Both changes depend on each other due to the PR checker, therefore they need to be merged in sync. |
mfasDa
changed the title
- EMCAL raw parser uses RDHAny and RDHUtils instead of a fixed raw version, needs adaption in accessing header fields - RawReaderMemory and AltroDecoder are no longer templated due to the change to RDHAny Change necessary due to the commit in O2: AliceO2Group/AliceO2#4128
Collaborator
|
Two builds, o2/cc7 and o-dataflow/macOS have passed, I don't expect any failures in cc7/o2-dataflow. Merging, as this is urgent to unblock failing CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
of a fixed raw version, needs adaption in accessing header
fields
templated due to the change to RDHAny
Change necessary due to the commit in O2: [EMCAL-646] Adapt EMCAL raw reader to time-based format AliceO2#4128