[QC-421] Allow to check PP tasks results in CheckRunners#506
Merged
Conversation
knopers8
changed the title
Collaborator
Author
|
@Barthelemy Could you have a look when you have some time? |
Barthelemy
approved these changes
Oct 14, 2020
| (void)_key; | ||
| if (dataSource.get<std::string>("type") == "Task" || dataSource.get<std::string>("type") == "ExternalTask") { | ||
| if (auto sourceType = dataSource.get<std::string>("type"); | ||
| sourceType == "Task" || sourceType == "ExternalTask" || sourceType == "PostProcessing") { |
Collaborator
There was a problem hiding this comment.
I see what you mean with "it is not very elegant all these OR conditions" however I am glad to know that we can declare a variable inside a if clause, this is new to me.
Collaborator
Author
There was a problem hiding this comment.
This is since c++17
njacazio
pushed a commit
to njacazio/QualityControl
that referenced
this pull request
Oct 19, 2020
…p#506) * [QC-421] Allow to check PP tasks results in CheckRunners * fix infrastructuregenerator test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done, but needs QC-420 merged first.