MCH: Added Processing of Digits and Preclusters#515
Conversation
seperrin
commented
Oct 13, 2020
seperrin
commented
- Added PhysicsTasks for digits and preclusters processing
- Added basic Check of occupancy level
- Added Reductor and PostProcessing code for TrendingTasks
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
Thank you for your contribution, great job !
I don't have many comments. Once you have considered the one about the PostProcessing, let me know and I will approve and merge.
| @@ -0,0 +1,71 @@ | |||
| // Copyright CERN and copyright holders of ALICE O2. This software is | |||
There was a problem hiding this comment.
It seems that MCHPostProcessing is a copy of TrendingTask. Is it because you did not implement it ? if so I would propose to remove it from the PR. Or is it because you use it ? if so, I would propose to simply use TrendingTask instead.
There was a problem hiding this comment.
I think I call it at some point in a .json config file for the TrendingTask, I must have thought that it was useful to have a copy of TrendingTask in the MCH repo but now I don't understand why... I'll try and see what happens if I use TrendingTask in my json instead, and correct all this.
There was a problem hiding this comment.
Yep, it works perfectly fine without this file, I'll remove it then and use TrendingTask instead :)
| namespace o2::quality_control_modules::muonchambers | ||
| { | ||
|
|
||
| /// \brief Check whether a plot is empty or not. |
There was a problem hiding this comment.
Update the description and author
| int parity = CheckDataParity(ds->data); | ||
| if (parity) | ||
| fprintf(flog, "===> SAMPA [%2d]: WARNING Parity %d\n", ds->id, parity); | ||
| fprintf(flog, "===> SAMPA [%d %d %2d]: WARNING Parity %d\n", ds->hit.cru_id, ds->hit.link_id, ds->id, parity); |
There was a problem hiding this comment.
I would propose to use the infologger instead of logging to a file but I presume that is just for helping the debugging now ?
There was a problem hiding this comment.
@aferrero2707 , do we still need the file log ?
There was a problem hiding this comment.
@seperrin @Barthelemy we can safely remove those fprintf statements. In fact, the whole internal decoding will become obsolete once we will have moved all our QC tasks to the official O2 decoding. We will only keep it around for a short while in order to be able to do some crosschecks...
|
@awegrzyn I get an error on macOS builder with the compilation of Monitoring. Does it ring a bell ? |
|
Nope, I've just tried on my Mac and no error :| |
|
@Barthelemy it looks like that now it fails on QC creating Configuration. |
|
@awegrzyn ok, on it |
- Added PhysicsTasks for digits and preclusters processing - Added basic Check of occupancy level - Added Reductor and PostProcessing code for TrendingTasks
seperrin
force-pushed
the
mch-digits-preclusters
branch
from
2431026 to
f70a7dd
Compare
- Added PhysicsTasks for digits and preclusters processing - Added basic Check of occupancy level - Added Reductor and PostProcessing code for TrendingTasks
4 participants
