[QC-463] Daqtask only publish included det#527
Merged
Barthelemy merged 3 commits intoOct 28, 2020
Merged
Conversation
Barthelemy
changed the title
knopers8
approved these changes
Oct 27, 2020
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thanks! The code will grow in a bit ugly way if the number of histogram kinds grows, but we can address that later.
Collaborator
Author
|
I agree on the fact that it should be rewritten when the number of plots grows. |
Collaborator
|
We could have some kind of extended map, which automatically creates and registers histograms if you try to access a new key. |
Collaborator
Author
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.