modified json to trigger on new object#574
Merged
Merged
Conversation
Contributor
|
Hi @Barthelemy, is it really a clang-format error there as we only modified the json? Thanks. |
Collaborator
|
@JianLIUhep I have to check, it is a new check that replaces travis. |
Collaborator
|
#575 should fix it. |
Collaborator
Author
|
Should I close and reopen the PR after #575 is merged or it goes automatically? |
Collaborator
|
no, I am just waiting for 02-dataflow to finish and if it is ok I will force-merge. |
Collaborator
|
errors are unrelated |
njacazio
pushed a commit
to alicetof/QualityControl
that referenced
this pull request
Jan 13, 2021
knopers8
pushed a commit
to knopers8/QualityControl
that referenced
this pull request
Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.