Skip to content

Avoid problem if no file is a c++ file #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 6 commits into from
Dec 16, 2020
Merged

Avoid problem if no file is a c++ file #575

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6e3a47
Avoid problem if no file is a c++ file
Barthelemy Dec 15, 2020
be65c79
test
Barthelemy Dec 15, 2020
55b966b
Update format.yml
Barthelemy Dec 15, 2020
baeefb1
Update format.yml
Barthelemy Dec 15, 2020
2a6f9e1
Update format.yml
Barthelemy Dec 15, 2020
b73028a
Update format.yml
Barthelemy Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,16 @@ jobs:
git fetch origin ${{ github.event.pull_request.base.ref }}
git fetch origin pull/${{ github.event.pull_request.number }}/head:${{ github.event.pull_request.head.ref }}
BASE_COMMIT=$(git rev-parse ${{ github.event.pull_request.base.sha }})
COMMIT_FILES=$(git diff --name-only ${BASE_COMMIT} | grep -E -- '\.cxx|\.h' | grep -i -v LinkDef)
COMMIT_FILES=$(git diff --name-only ${BASE_COMMIT} | grep -E -- '\.cxx|\.h' | grep -i -v LinkDef) || true ;# avoid failures if nothing is greped
if [ "$COMMIT_FILES" == "" ]; then
exit 0 ;# nothing to check
fi

RESULT_OUTPUT=$(git-clang-format-8 --commit ${BASE_COMMIT} --diff --binary $(which clang-format-8) ${COMMIT_FILES})
if [ "$RESULT_OUTPUT" == "no modified files to format" ] || [ "$RESULT_OUTPUT" == "clang-format did not modify any files" ]; then
exit 0
exit 0 ;# all good
else
git-clang-format-8 --commit $BASE_COMMIT --diff --binary $(which clang-format-8)
echo "$RESULT_OUTPUT"
exit 1
fi
fi