Skip to content

[EMCAL-524,EMCAL-526] Plots for different trigger classes#585

Closed
cterrevo wants to merge 2 commits into
AliceO2Group:masterfrom
cterrevo:EMCAL-524
Closed

[EMCAL-524,EMCAL-526] Plots for different trigger classes#585
cterrevo wants to merge 2 commits into
AliceO2Group:masterfrom
cterrevo:EMCAL-524

Conversation

@cterrevo
Copy link
Copy Markdown
Contributor

Create and fill QA plots for Calib and Physics Triggers in Raw and Digit
tasks

Create and fill QA plots for Calib and Physics Triggers in Raw and Digit
tasks
Copy link
Copy Markdown
Collaborator

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just 1 comment.

auto triggertype = trg.getTriggerBits();
bool isPhysTrigger = triggertype & o2::trigger::PhT, isCalibTrigger = triggertype & o2::trigger::Cal;
std::string trgClass;
if (isPhysTrigger)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we recommend to always add curvy braces.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we take this as recommendation :)

@Barthelemy
Copy link
Copy Markdown
Collaborator

@ktf @TimoWilken I think that there is something wrong with the mac builder.

@TimoWilken
Copy link
Copy Markdown
Contributor

@Barthelemy looking into it!

@TimoWilken
Copy link
Copy Markdown
Contributor

@Barthelemy I think I've found the issue - the build timed out, very probably because of a corrupt git repo for some dependencies. I've fixed it for now and I'll have a look at how to prevent this in future. In the meantime, I've marked the failed builds as pending so they run again.

@mfasDa
Copy link
Copy Markdown
Collaborator

mfasDa commented Jan 13, 2021

To make clear: We need a change in O2, because we need to propagate the trigger bits in one of our headers in order to distinguish different triggers. The change is merged into dev there.

We tested the change with the data we just collected the past few days with the expected setup for the VS test and we are ready with this. It is important for us to get this commit merged before the MW1.

@Barthelemy
Copy link
Copy Markdown
Collaborator

@mfasDa There are real errors in the o2 build that must be fixed, otherwise it would break everything.
For the mac build, I am not sure why it fails if the change in O2 is there. Or is it just an old build ?

I am not sure that it is possible to have it in time for MW1 to be honest. We need to have the CI pass here, create a new version of QC before the FLP suite is locked.

@mfasDa
Copy link
Copy Markdown
Collaborator

mfasDa commented Jan 14, 2021

Should be closed as the PR is split into a PR for the raw task #590 which does not rely on changes in O2 and should be handled with priority, and a commit for the cell task #589 which relies on changes in O2.

@Barthelemy Barthelemy closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants