Skip to content

Use new TPC cluster reader helper to avoid copy&pasted code#593

Merged
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
davidrohr:master_pull_request
Jan 26, 2021
Merged

Use new TPC cluster reader helper to avoid copy&pasted code#593
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
davidrohr:master_pull_request

Conversation

@davidrohr
Copy link
Copy Markdown
Contributor

no functionall change, just getting rid of some copy&pasted code, tested already and histograms are published to the qcg-test website in the same way as before.

@davidrohr
Copy link
Copy Markdown
Contributor Author

@Barthelemy @TimoWilken : What is QC/o2-dataflow tested against? Is it o2 dev branch? I am wondering how it can still fail, since the problem in O2 is fixed, and I could compile O2 and QC with my patch with o2-dataflow defaults locally.

@Barthelemy
Copy link
Copy Markdown
Collaborator

I am not sure. Timo, could you check ? I suspect that it is against the alidist defined version of O2 which would be incorrect.

@TimoWilken
Copy link
Copy Markdown
Contributor

@davidrohr @Barthelemy it's tested against what's defined in the master branch of alidist, so right now it's v21.01.

@davidrohr
Copy link
Copy Markdown
Contributor Author

ok, so this is the reason why it is failing, since the tag lacks the latest fixes in O2/dev. Shouldn't it be checked against dev?

@Barthelemy
Copy link
Copy Markdown
Collaborator

I agree, I would prefer if it was tested against dev.

@TimoWilken
Copy link
Copy Markdown
Contributor

See: alisw/ali-bot#931

@davidrohr
Copy link
Copy Markdown
Contributor Author

@Barthelemy : Something is stange here. Both dataflow CIs have been green during the day, but now they are failing again somewhere else.

@Barthelemy
Copy link
Copy Markdown
Collaborator

I don't even find where it is failing... Could it be the same as in #589 (comment) ? @TimoWilken @ktf any idea ?

@davidrohr
Copy link
Copy Markdown
Contributor Author

Now all CIs are failing without any indication what is going wrong @Barthelemy @TimoWilken

@Barthelemy
Copy link
Copy Markdown
Collaborator

@ktf @TimoWilken Could you check ?

@davidrohr
Copy link
Copy Markdown
Contributor Author

@Barthelemy : It is finally green :)
Could you merge it?

@Barthelemy Barthelemy merged commit 1a329b1 into AliceO2Group:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants