[WIP] [QC-558] Fix the facility in IL

[Barthelemy]

Make sure that we set the facility after all the constructors have been called.

[Barthelemy]

@TimoWilken The clang format test is failing on the prerequisite. Could you have a look ?

[Barthelemy]

@ktf

[Barthelemy]

@ktf @TimoWilken also o2 build failed without logs

[TimoWilken]

@Barthelemy looking into O2; the clang-format failure has already been reported to GitHub.

[Barthelemy]

@TimoWilken I don't undersatnd why o2 test is red.

[TimoWilken]

I've cleaned out the previous build and restarted the o2 check. Hopefully that should fix the problem.

[knopers8]

Oh, the old fairlogger problems from O2:

/mnt/mesos/sandbox/sandbox/qualitycontrol/sw/SOURCES/O2/build_QualityControl_o2/0/Detectors/ZDC/base/src/ModuleConfig.cxx:13:10: fatal error: FairLogger.h: No such file or directory
 #include <FairLogger.h>
          ^~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [Detectors/ZDC/base/CMakeFiles/O2lib-ZDCBase.dir/src/ModuleConfig.cxx.o] Error 1
[  2%] Built target O2test-datacompression-Fifo
/mnt/mesos/sandbox/sandbox/qualitycontrol/sw/SOURCES/O2/build_QualityControl_o2/0/Detectors/ZDC/base/src/Geometry.cxx:12:10: fatal error: FairLogger.h: No such file or directory
 #include "FairLogger.h"
          ^~~~~~~~~~~~~~
          ```

[knopers8]

Indeed, that makes sense.

I am actually wondering if we shouldn't even set the device name there, so we can differentiate between the tasks and checkers.

[Barthelemy]

I am actually wondering if we shouldn't even set the device name there, so we can differentiate between the tasks and checkers.

Yes, good idea. We lack a field actually. Because "facility" is Task, Check but we need to set a "process name". As it is not there, I agree that we could use the facility for that. I will modify this PR accordingly.

[Barthelemy]

Closing in favour of #646