[MCH] [MRRTF-108] Prepare for digit move#647
Merged
Barthelemy merged 2 commits intoMar 22, 2021
Merged
Conversation
Contributor
Author
|
@aferrero2707 this is to avoid breaking the QC compilation when we'll change the home of our MCH Digit.h (in a forthcoming PR in AliceO2) |
aphecetche
changed the title
Barthelemy
requested changes
Mar 22, 2021
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
The file Modules/Example/README.md seems to have been automatically added. Could you remove it ?
Otherwise, all good !
aphecetche
force-pushed
the
mch-prepare-for-digit-move
branch
from
beb3cdd to
6aad19c
Compare
Contributor
Author
|
@Barthelemy have no idea how this empty Modules/Example/README.md ended up there, but it should be fixed now. |
Barthelemy
approved these changes
Mar 22, 2021
Contributor
Author
|
@Barthelemy all green |
Barthelemy
pushed a commit
to Barthelemy/QualityControl
that referenced
this pull request
Mar 22, 2021
* - * [MCH] Preparation for Digit.h move in O2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will be moving Digit.h from MCHBase to DataFormatsMCH in AliceO2.
This PR hopefully makes the QC immune to that forthcoming change.