HMPID_NewDigitStructure

[fapfap69]

No description provided.

[knopers8]

Accepting, but let's see what the CI says (as a first-time contributor, your PR would not be checked before being accepted).

[fapfap69]

Accepting, but let's see what the CI says (as a first-time contributor, your PR would not be checked before being accepted).

Hi Piotr,
I experienced some problems with includes.
In this version we moved some source files in O2/Detectors and O2/DataFormats.
The compilation, on my MAC Installation works fine !
But fails in the PR check :(

I'd try to modify the Cmake file in order to target this includes, with no positive results.
Please could you indicate to my, references to how set the CMakefiles to target O2 includes, external to the QC ?

Thanks a lot

[knopers8]

@fapfap69 Just a quick question before we investigate it deeper. Don't you need AliceO2Group/AliceO2#5795 merged first to make this PR here compile? In our checks we compile PRs against O2@dev.

[fapfap69]

@fapfap69 Just a quick question before we investigate it deeper. Don't you need AliceO2Group/AliceO2#5795 merged first to make this PR here compile? In our checks we compile PRs against O2@dev.

Ya. you are right ! I'm really stupid :)
Thanks a lot !!

[gvolpe79]

Hi Piotr,
it seems that now the compilation is giving error not on the HMPID code, right?!

[knopers8]

Yes, this is a general problem in the CI and has been reported to the admins ( https://alice.its.cern.ch/jira/browse/O2-2214 ). However, the build fails before it reaches the HMPID code in QC, so we cannot know if it compiles now correctly.

[knopers8]

The o2 build shows the usual Logger errors, but I will force merge, since the other two builds are passing.