Skip to content

[QC-565] Set run number on objects#658

Merged
knopers8 merged 12 commits into
AliceO2Group:masterfrom
Barthelemy:set-run-number-objects
Apr 13, 2021
Merged

[QC-565] Set run number on objects#658
knopers8 merged 12 commits into
AliceO2Group:masterfrom
Barthelemy:set-run-number-objects

Conversation

@Barthelemy
Copy link
Copy Markdown
Collaborator

No description provided.

@Barthelemy Barthelemy requested a review from knopers8 March 30, 2021 06:28
@Barthelemy
Copy link
Copy Markdown
Collaborator Author

There seems to be room for improvement with regards to the *Runners family as they share quite some functionalities and code. To be seen.

Copy link
Copy Markdown
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you. Please see my two questions.

Comment thread Framework/src/CcdbDatabase.cxx Outdated
Comment thread Framework/src/MonitorObject.cxx Outdated
@Barthelemy
Copy link
Copy Markdown
Collaborator Author

I will also fix the tests that apparently started failing.

Comment thread Framework/script/RepoCleaner/README.md
Comment thread Framework/src/TaskRunner.cxx
Comment thread Modules/Skeleton/src/SkeletonTask.cxx Outdated
@Barthelemy Barthelemy requested a review from knopers8 April 13, 2021 08:29
@knopers8 knopers8 merged commit 74243e2 into AliceO2Group:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants