CPV Pedestal Task & Check #662
Conversation
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
I did not read in details the logic of the task and check but what I read was ok.
| { | ||
| for (int i = 0; i < kNHist1D; i++) { | ||
| if (mHist1D[i]) { | ||
| mHist1D[i]->Delete(); |
There was a problem hiding this comment.
is there a particular reason not to use delete mHist1D[i] ?
There was a problem hiding this comment.
no, there is no reason.
There was a problem hiding this comment.
I tried to understand the difference between histo->Delete() and delete histo and they both call destructor but first case contains additional check IsOnHeap(). Whatever this check is I prefer to get rid of it just to be 100% sure histo is deleted. In future commits I will replace mHist1D[i]->Delete() by delete mHist1D[i] as you suggested.
|
Dear Barth, there are some errors during build which I don't understand. Could you please tell me what went wrong this time? |
|
They are spurrious https://alice.its.cern.ch/jira/browse/O2-2214 I am waiting for the macos test |
2 participants
CPV Pedestal Task & Check created. Task takes digits and digit trigger records as input and produces Pedestal Monitoring objects: 1D historgrams of amplitudes for every channel (~24K histos total) which are used to produce pedestal maps for modules, count pedestal sigmas and so on. Check is performed to see how many bad channels of different reasons we have. Overall detector quality is produced (1 QO) then. Configurable are channel badness criteria and tolerated numbers of bad channels of different types. Config is read from json file. See Modules/CPV/etc/read-raw-from-file/pedestal-task-no-sampling.json for example. And also Modules/CPV/etc/readme for run recipe.