[O2-2018] No need to link to ms_gsl...#691
Conversation
... which is to be renamed to Microsoft.GSL::GSL anyway
|
For the record, this one is needed by AliceO2Group/AliceO2#6075 |
|
@TimoWilken any idea what are the timeout failures for build/QualityControl/o2 ? |
|
I don't know, sorry. I've restarted it for now, let me know if that doesn't fix it. |
|
@TimoWilken the error is unfortunately still present. @Barthelemy maybe this is something you've already observed ? |
|
@TimoWilken @Barthelemy don't know what changed but now it's green, ready to be merged 😄 |
|
I am not sure but it feels like it is an issue with the compiler version and the c++ standard version in O2/Common. @ktf what do you think ? |
|
It is this PR that was merged although |
|
sorry for that, I think the dataflow in the original PR was green at some stage, then I had some incremental changes in other files. The boost::fs was creating problems, so the change is needed. |
|
|
... which is to be renamed to Microsoft.GSL::GSL anyway