Skip to content

[O2-2018] No need to link to ms_gsl...#691

Merged
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
aphecetche:o2-2018-no-need-for-direct-link-to-ms-gsl
May 10, 2021
Merged

[O2-2018] No need to link to ms_gsl...#691
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
aphecetche:o2-2018-no-need-for-direct-link-to-ms-gsl

Conversation

@aphecetche
Copy link
Copy Markdown
Contributor

... which is to be renamed to Microsoft.GSL::GSL anyway

... which is to be renamed to Microsoft.GSL::GSL anyway
@aphecetche
Copy link
Copy Markdown
Contributor Author

For the record, this one is needed by AliceO2Group/AliceO2#6075

@aphecetche
Copy link
Copy Markdown
Contributor Author

@TimoWilken any idea what are the timeout failures for build/QualityControl/o2 ?

@TimoWilken
Copy link
Copy Markdown
Contributor

I don't know, sorry. I've restarted it for now, let me know if that doesn't fix it.

@aphecetche
Copy link
Copy Markdown
Contributor Author

@TimoWilken the error is unfortunately still present. @Barthelemy maybe this is something you've already observed ?

@aphecetche
Copy link
Copy Markdown
Contributor Author

@TimoWilken @Barthelemy don't know what changed but now it's green, ready to be merged 😄

@Barthelemy
Copy link
Copy Markdown
Collaborator

Barthelemy commented May 10, 2021

I am not sure but it feels like it is an issue with the compiler version and the c++ standard version in O2/Common. @ktf what do you think ?

@Barthelemy
Copy link
Copy Markdown
Collaborator

It is this PR that was merged although o2-dataflow was red: AliceO2Group/AliceO2#6102

@shahor02
Copy link
Copy Markdown
Contributor

sorry for that, I think the dataflow in the original PR was green at some stage, then I had some incremental changes in other files. The boost::fs was creating problems, so the change is needed.
@ktf do you understand why in some cases it fails to find the header?

@Barthelemy
Copy link
Copy Markdown
Collaborator

o2-dataflow is broken until we move to gcc10, ignoring the check failure.
See AliceO2Group/AliceO2#6102

@Barthelemy Barthelemy merged commit d7c5cc9 into AliceO2Group:master May 10, 2021
@aphecetche aphecetche deleted the o2-2018-no-need-for-direct-link-to-ms-gsl branch May 10, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants