Skip to content

TPC Trending json (Tracks and PID)#704

Merged
Barthelemy merged 3 commits into
AliceO2Group:masterfrom
mlesch:master
May 19, 2021
Merged

TPC Trending json (Tracks and PID)#704
Barthelemy merged 3 commits into
AliceO2Group:masterfrom
mlesch:master

Conversation

@mlesch
Copy link
Copy Markdown
Contributor

@mlesch mlesch commented May 18, 2021

No description provided.

@stheckel
Copy link
Copy Markdown
Contributor

Hi Marcel,
thanks for the trending json! One comment: In the CMakeList, can you please instead of changing the name of the json just add the new one? Otherwise the old file could not be run anymore.
Thanks and cheers,
Stefan

@mlesch
Copy link
Copy Markdown
Contributor Author

mlesch commented May 18, 2021

Hi Stefan,
Thanks for the comment, it is updated now.
Cheers,
Marcel

@stheckel
Copy link
Copy Markdown
Contributor

Hi @Barthelemy, hi @knopers8,
could you have a look at this PR and approve it? Its just a json file for some TPC trendings. Jens approved it, but this seems not to be enough to start the checks.
Thanks and cheers,
Stefan

@stheckel
Copy link
Copy Markdown
Contributor

Hi,
this is strange, two checks fail although this is just a json configuration file. The issue is in a memory test and the same issue is also observed in another PR. So I guess, it is not related to these commits here, but I am also not entirely sure...

@Barthelemy Barthelemy merged commit a00c9fb into AliceO2Group:master May 19, 2021
@Barthelemy
Copy link
Copy Markdown
Collaborator

The failures are not even in QC. They are in O2. I force merge.

@stheckel
Copy link
Copy Markdown
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants