Check for TOF DRM Diagnostics#717
Conversation
njacazio
left a comment
njacazio
left a comment
There was a problem hiding this comment.
Hi @pranjalsarma, great work indeed! we just would need to specify the checks and we are set!
|
|
||
| for (int i = 1; i < h->GetNbinsX(); i++) { | ||
| for (int j = 1; j < h->GetNbinsY(); j++) { | ||
| const float content = h->GetBinContent(i, j); |
There was a problem hiding this comment.
@pranjalsarma perfect! Here we can check that the histogram does not have bins with errors inside. The meaning of each bin should be this one: https://github.com/AliceO2Group/AliceO2/blob/dev/DataFormats/Detectors/TOF/include/DataFormatsTOF/CompressedDataFormat.h#L118-L134 I think that we can skip the first bin (HAS_DATA) because this is fine.
| if (checkResult == Quality::Bad) { | ||
| ILOG(Info, Support) << "Quality::Bad, Error bins with content >0"; | ||
| msg->Clear(); | ||
| msg->AddText("Error bins with content >0"); |
There was a problem hiding this comment.
I would adjust the message accordingly, with something e.g. "DRM reporting error words"
| "type": "Task", | ||
| "name": "TaskRaw", | ||
| "MOs": [ | ||
| "RDHCounterCrate0" |
There was a problem hiding this comment.
This should be the DRMCounter no?
There was a problem hiding this comment.
In the CheckDiagnostics.cxx file it is given as RDH.
| "type": "Task", | ||
| "name": "TaskRaw", | ||
| "MOs": [ | ||
| "RDHCounterCrate0" |
There was a problem hiding this comment.
Idem, This should be the name of the histogram that you are processing in the checker
|
Spurrious check errors, merging. |
3 participants
Hi @njacazio,
PR for DRM Diagnostics is created. Please have look.
Best regards,
Pranjal