Fixed issues with the geometry file for Cluster and Track tasks#764
Merged
Conversation
Contributor
|
Hi @IsakovAD, thanks for quickly submitting this PR. Could you please modify the title to a meaningful one so that we can track changes clearly. Thank you. @knopers8, this PR will fix some problems we spotted during the test on EPN yesterday. Would it be feasible we tag this version and update the QC on EPNs (or at least the 20 ITS EPNs)? Thanks a lot. |
IsakovAD
changed the title
Collaborator
|
@JianLIUhep EPNs are beyond my influence, but at least I can make a QC release. |
knopers8
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated ClusterTask: moved geometry path initialization later
Updated Track Task: removed the mGeometry file since we do not use it for the TrackTask. Added a path to the run number file as a parameter from the .jsom file. Applied a clang format to the .json file for the Track Task
For some reason, the diff in a pull request also includes changes from my previous commit, when at the Master branch those changes already present for a long time. (To be more clear, changes in Modules/ITS/include/ITS/ITSClusterTask.h and Modules/ITS/itsCluster.json, Modules/ITS/src/ITSClusterTask.cxx are already in the master branch: a49df9a)