TPC: configurable histogram ranges#768
Merged
Merged
Conversation
wiechula
requested changes
Jul 15, 2021
wiechula
requested changes
Jul 19, 2021
tklemenz
force-pushed
the
varRanges
branch
2 times, most recently
from
61fbcac to
1bb851e
Compare
wiechula
requested changes
Jul 19, 2021
Make output histogram ranges of Cluster and RawDigits task configurable via json file.
tklemenz
changed the title
Barthelemy
reviewed
Jul 20, 2021
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
Good for me, I would just ask to reconsider the monitor cycle of 10 seconds.
| "moduleName": "QcTPC", | ||
| "detectorName": "TPC", | ||
| "cycleDurationSeconds": "60", | ||
| "cycleDurationSeconds": "10", |
Collaborator
There was a problem hiding this comment.
Are you sure about this one ? publishing every 10 seconds is quite a lot.
Contributor
Author
There was a problem hiding this comment.
Yes, this is for testing only anyway so it doesn't really matter.
Barthelemy
approved these changes
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make output histogram ranges of Cluster and RawDigits task configurable via json file.