[EMCAL-524] fix binnings for ampl. and time histos#781
Merged
Conversation
mfasDa
approved these changes
Jul 23, 2021
Collaborator
mfasDa
left a comment
mfasDa
left a comment
There was a problem hiding this comment.
Looks good. Should be merged. We use the actual amount of bins in order to reduce the in-memory size a bit. Local tests with the profiler however indicate that we need to drastically reduce the size of the output objects as we spend 99% of the time the task consums in sending the histograms via shmem transport.
Collaborator
|
error unrelated, merging. |
Collaborator
|
@TimoWilken Could you check why build/QualityControl/o2 failed ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.