[EMCAL-524] Make histograms vs cell ID optional#792
Conversation
| std::string getConfigValue(const std::string_view key); | ||
| std::string getConfigValueLower(const std::string_view key); |
There was a problem hiding this comment.
@knopers8 @Barthelemy Could those functions be pushed upwards to the TaskInterface?
Actually I am thinking about something similar to what is done for the Options by the framework having variant data types for int, float, bool and string, and a template function casting to the required type. (Would remove the need for the lambdas I am using to extract bool and float from the string myself)
There was a problem hiding this comment.
I created a ticket: https://alice.its.cern.ch/jira/browse/QC-632
- Move filling of all hisstograms to a separate function fillHistograms of DigitsHistograms, this makes handling of optional histograms a lot easier - Use lamdba functions for fill/reset/delete of optional histograms - Disable all 2D histograms except occupancy for the LED events - Add functions for easy access to task parameters
mfasDa
changed the title
|
Tests work fine - @knopers8 @Barthelemy please merge when the build checks are done |
| delete hist; | ||
| }; | ||
|
|
||
| cleanOptional(mDigitTime); |
There was a problem hiding this comment.
FYI, deleting nullptr has no effect:
https://stackoverflow.com/questions/6731331/is-it-still-safe-to-delete-nullptr-in-c0x
- Move filling of all hisstograms to a separate function fillHistograms of DigitsHistograms, this makes handling of optional histograms a lot easier - Use lamdba functions for fill/reset/delete of optional histograms - Disable all 2D histograms except occupancy for the LED events - Add functions for easy access to task parameters
Bug introduced in AliceO2Group#792: Supemodule ID was not checked against range, therefore all supermodules treated as EMCAL supermodules.
Bug introduced in #792: Supemodule ID was not checked against range, therefore all supermodules treated as EMCAL supermodules.
2 participants
fillHistograms of DigitsHistograms, this makes
handling of optional histograms a lot easier
optional histograms
the LED events