[QC-627] Set proper ownership of MO collection after deserialization#798
Merged
Merged
Conversation
Collaborator
Author
knopers8
changed the title
Barthelemy
approved these changes
Aug 9, 2021
| } | ||
| this->SetOwner(true); | ||
| delete it; | ||
| } |
Collaborator
There was a problem hiding this comment.
ROOT objects ownership at its best.
Collaborator
|
test failure unrelated, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the leaks reported in QC-627. The problem was that
MonitorObjectsinMonitorObjectCollectionwere indeed deleted, but they did not own the contained objects, so those were not.As far as I could see, ROOT does not offer any method which allows to correct ownership after deserialization, so I added one in AliceO2Group/AliceO2#6811 and made sure it is executed after the received objects are unpacked.
In
CheckRunnerwe used to assume thatTObjArrayis always non-owning, I had to fix that.