Cleanup MID Raw QC task#817
Merged
Merged
Conversation
Barthelemy
approved these changes
Aug 27, 2021
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
Thanks for the explanation, all good then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some old executables and cleans up the MID QC Raw task, so that it can be used in an AliECS workflow.
Notice that the old executable conflicts with some O2 development. I therefore need to first merge this before pushing the modifications in O2, in order not to break QC compilation.
Notice also that, in the cleanup, I commented the code instead of removing it since I am not the QC developer. In this way the relevant people will more easily fix the executable and put it back.
The commits are intended to be atomic. Please do not squash them.