[QC-443] Represent Checks configuration as C++ structures#823
Merged
Conversation
Includes also PostProcessingTaskSpec and ExternalTaskSpec, but these are only used by CheckRunners so far.
knopers8
force-pushed
the
structurize-config
branch
from
f31c1a6 to
cd977ba
Compare
Barthelemy
approved these changes
Sep 6, 2021
| return passName; | ||
| } | ||
|
|
||
| inline std::string computeProvenance(const std::string& fallbackProvenance = "") |
Collaborator
There was a problem hiding this comment.
I think that there is a rebase that is missing because these lines were added in another PR.
Collaborator
Author
There was a problem hiding this comment.
I do not understand what is the problem. For now there are two copies of compute* functions until we stop using the ones which require the whole ptree (aggregators still use them).
Collaborator
There was a problem hiding this comment.
oh, sorry, I had misunderstood what was going on. All good !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes also PostProcessingTaskSpec and ExternalTaskSpec, but these are only
used by CheckRunners so far.
Not the last PR for this issue...