Skip to content

TPC: fixed Cluster and RawDigit tasks#847

Merged
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
tklemenz:fixClusterRawDigi
Oct 4, 2021
Merged

TPC: fixed Cluster and RawDigit tasks#847
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
tklemenz:fixClusterRawDigi

Conversation

@tklemenz
Copy link
Copy Markdown
Contributor

@tklemenz tklemenz commented Sep 30, 2021

  • normalization to number of clusters did not work properly

@tklemenz tklemenz requested a review from wiechula as a code owner September 30, 2021 06:45
@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented Sep 30, 2021

Needs AliceO2Group/AliceO2#7168 before merging.

@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented Sep 30, 2021

Why does the check for clang-format fail even though I ran it?
Is clang-format-6.0 -style=file -i <filename> wrong now?

@tklemenz tklemenz changed the title [WIP] TPC: fixed Cluster and RawDigit tasks TPC: fixed Cluster and RawDigit tasks Sep 30, 2021
@Barthelemy
Copy link
Copy Markdown
Collaborator

Barthelemy commented Sep 30, 2021

@tklemenz clang-format does not report problems on my machine either. Some extra space at the end of CheckRunner ? that's real strange.

@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented Sep 30, 2021

Indeed running clang-format on CheckRunner.cxx changed the file. Apparently it did not conform.
Shall I include the file in this PR or do you want to do a separate one?

@Barthelemy
Copy link
Copy Markdown
Collaborator

Barthelemy commented Sep 30, 2021

@tklemenz Please include it in this PR even if it is not consistent with the title. I prefer to know that the change is in
The other errors seems legit ? a change is needed in O2 ?

@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented Sep 30, 2021

Yes as mentioned in an earlier comment one PR in O2 is needed. But no circular dependencies this time. :)

@tklemenz
TPC: fixed Cluster and RawDigit tasks
9f55838 
 - normalization to number of clusters did not work properly
@Barthelemy Barthelemy merged commit 1efe8cc into AliceO2Group:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Barthelemy Barthelemy Barthelemy approved these changes

@wiechula wiechula wiechula approved these changes

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tklemenz @Barthelemy @wiechula