MCH: improved naming and location of digits task histograms#848
Merged
Barthelemy merged 2 commits intoOct 1, 2021
Merged
Conversation
The DE-specific occupancy histograms are moved into sub-folders, following the convention "STx/DExxx/". This allows to only have global histograms in the root "QcTaskMCHDigits" folder. Histogram names have also been shortened for better readability.
aferrero2707
force-pushed
the
mch-digits-task-improved-histo-naming
branch
from
5531041 to
f79db02
Compare
Also reduced the ADC threshold for filling the occupancy plots from 100 to 50 ADC units
aferrero2707
force-pushed
the
mch-digits-task-improved-histo-naming
branch
from
f79db02 to
98e1633
Compare
Collaborator
|
@TimoWilken @ktf Macos build failed without logs |
Barthelemy
approved these changes
Sep 30, 2021
|
|
||
| static std::string getHistoPath(int deId) | ||
| { | ||
| return fmt::format("ST{}/DE{}/", (deId - 100) / 200 + 1, deId); |
Contributor
Author
There was a problem hiding this comment.
Yes, but graved in the stone ;-)
Contributor
It was a temporary failure fetching a dependency, I've restarted the check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DE-specific occupancy histograms are moved into sub-folders, following the convention "STx/DExxx/".
This allows to only have global histograms in the root "QcTaskMCHDigits" folder.
Histogram names have also been shortened for better readability.