Skip to content

FT0: Extension of the module for pilot beams#851

Merged
Barthelemy merged 14 commits into
AliceO2Group:masterfrom
sbysiak:feature-pilot-beam
Oct 4, 2021
Merged

FT0: Extension of the module for pilot beams#851
Barthelemy merged 14 commits into
AliceO2Group:masterfrom
sbysiak:feature-pilot-beam

Conversation

@sbysiak
Copy link
Copy Markdown
Contributor

@sbysiak sbysiak commented Sep 30, 2021

Main changes:

  • two new postprocessing tasks
  • one new check
  • extension of DigitQcTask by adding new histograms and option to change the binning of any histogram via config file

@sbysiak
FT0: Add new histos to DigitQcTask
9acfbf9 
Adds two new histos:
- mHistTimeSum2Diff;
- mHistTriggersCorrelation
@sbysiak
FT0: add trigger rates via postprocessing
fc5076e 
Add new class `BasicPPTask`.
Also modifies DigitQcTask by adding hist with cycle duration
@sbysiak
FT0: Add time and ampl TProfiles to BasicPPTask
938d456
@sbysiak
FT0: Add new postprocessing OutOfBunchCollTask
4a456a4 
- add bc-orbit map for each trigger in DigitQcTask
- add OutOfBunchCollTask
    to find collision outside of provided bcPattern
- add BC hist to DigitQcTask [minor]
@sbysiak
FT0: Add configurable binning
064a22c
@sbysiak
FT0: add CFD hist do DigitQcTask
1f16e93
@sbysiak
FT0: minor visual changes
0acc5db 
- swap x-y in two TH2
@sbysiak
FT0: Add CFDEffCheck
4a6f9f4
@sbysiak
FT0: fix in BasicPPTask - switch to smart pointers
495ada8 
- only for TGraph and TCanvas, problem with TProfile
@sbysiak sbysiak changed the title Extension of FT0 module for pilot beams FT0: Extension of the module for pilot beams Sep 30, 2021
@sbysiak
Copy link
Copy Markdown
Contributor Author

sbysiak commented Oct 2, 2021

Small fix added

sbysiak added 4 commits October 3, 2021 00:47
@sbysiak
FT0: fix clang format
1716bce
@sbysiak
FT0: add TriggerQcTask
69b5bd7 
Adds new QcTask for verification of FEE (TCM) logic via software
@sbysiak
FT0: Add OutOfBunchCollCheck
6e179c2 
Adds new checker based on fraction of events which are out-of-bunch
For this metadata are also added to MOs in OutOfBunchCollTask
@sbysiak
FT0: minor changes in DigitQcTask
cd38691 
- add new hist for 3rd way of computing cycle duration (prefered if subsampling is used)
- change units in one hist (#channels -> ns)
@Barthelemy Barthelemy merged commit a51e427 into AliceO2Group:master Oct 4, 2021
@mfasDa
Copy link
Copy Markdown
Collaborator

mfasDa commented Oct 4, 2021

Breaks compilation under macOS - I guess a reference is needed in the range-based for loop:

/Library/Developer/CommandLineTools/usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_CONTAINER_DYN_LINK -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_IOSTREAMS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SERIALIZATION_DYN_LINK -DDPL_ENABLE_BACKTRACE -DFAIRMQ_HAS_STD_FILESYSTEM=1 -DFMT_LOCALE -DO2QcFT0_EXPORTS -D__CLANG_SUPPORT_DYN_ANNOTATION__ -I/Users/markusfasel/alice/sw/SOURCES/QualityControl/aliceo2/0/Modules/FT0/include -I/Users/markusfasel/alice/sw/SOURCES/QualityControl/aliceo2/0/Modules/FT0/src -I/Users/markusfasel/alice/sw/SOURCES/QualityControl/aliceo2/0/Modules/FT0 -I/Users/markusfasel/alice/sw/SOURCES/QualityControl/aliceo2/0/Framework/include -isystem /Users/markusfasel/alice/sw/osx_arm64/boost/v1.75.0-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/FairLogger/v1.10.1-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/fmt/7.1.0-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/FairMQ/v1.4.42-local1/include/fairmq -isystem /Users/markusfasel/alice/sw/osx_arm64/FairMQ/v1.4.42-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/ROOT/v6-24-06-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/Common-O2/v1.6.0-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/libInfoLogger/v2.1.1-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/Monitoring/v3.8.9-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/Configuration/v2.6.3-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/Control-OCCPlugin/v0.26.6-local1/include/Occ -isystem /Users/markusfasel/alice/sw/osx_arm64/grpc/v1.34.0-alice2-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/protobuf/v3.15.8-local1/include -isystem /opt/homebrew/opt/openssl@1.1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/c-ares/v1.17.1-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/re2/2019-09-01-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/abseil/20200225.2-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/O2/aliceo2-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/curl/7.70.0-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/O2/aliceo2-local1/include/GPU -isystem /Users/markusfasel/alice/sw/osx_arm64/FairRoot/v18.4.2-local2/include -isystem /Users/markusfasel/alice/sw/osx_arm64/arrow/v5.0.0-alice1-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/Vc/1.4.1-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/ms_gsl/3.1.0-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/libjalienO2/0.1.3-local1/include -isystem /Users/markusfasel/alice/sw/osx_arm64/RapidJSON/v1.1.0-alice2-local1/include -isystem /opt/homebrew/opt/libuv/include -fPIC -O2 -std=c++17 -Wno-error=deprecated-declarations -Wall -pedantic -Wextra -Werror -O2 -g -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -fPIC -std=gnu++17 -MD -MT Modules/FT0/CMakeFiles/O2QcFT0.dir/src/TriggerQcTask.cxx.o -MF Modules/FT0/CMakeFiles/O2QcFT0.dir/src/TriggerQcTask.cxx.o.d -o Modules/FT0/CMakeFiles/O2QcFT0.dir/src/TriggerQcTask.cxx.o -c /Users/markusfasel/alice/sw/SOURCES/QualityControl/aliceo2/0/Modules/FT0/src/TriggerQcTask.cxx
/Users/markusfasel/alice/sw/SOURCES/QualityControl/aliceo2/0/Modules/FT0/src/TriggerQcTask.cxx:31:21: error: loop variable 'choice' creates a copy from type 'const std::__1::pair<const unsigned int, std::__1::basic_string<char>>' [-Werror,-Wrange-loop-construct]
    for (const auto choice : choices) {
                    ^
/Users/markusfasel/alice/sw/SOURCES/QualityControl/aliceo2/0/Modules/FT0/src/TriggerQcTask.cxx:31:10: note: use reference type 'const std::__1::pair<const unsigned int, std::__1::basic_string<char>> &' to prevent copying
    for (const auto choice : choices) {
         ^~~~~~~~~~~~~~~~~~~
                    &
1 error generated.

@sbysiak sbysiak mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Barthelemy Barthelemy Barthelemy approved these changes

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbysiak @mfasDa @Barthelemy