Plots for fractions of fake added, using MC info#854
Merged
Conversation
njacazio
approved these changes
Oct 4, 2021
Collaborator
njacazio
left a comment
njacazio
left a comment
There was a problem hiding this comment.
Hi @chiarazampolli I think the code is good to go! Just the CI fixes are needed
| mMatchedTracksPt[trkType::UNCONS]->Fill(trk.getPt()); | ||
| mMatchedTracksEta[trkType::UNCONS]->Fill(trk.getEta()); | ||
| if (mUseMC) { | ||
| auto lbl = mRecoCont.getTrackMCLabel(gTrackId); |
Collaborator
There was a problem hiding this comment.
Hi @chiarazampolli indeed here probably the formatting CI fails
Contributor
Author
There was a problem hiding this comment.
Yes, I also noticed, sorry, I pushed now the fix.
clang-format
chiarazampolli
force-pushed
the
TOFmatchQCMC
branch
from
66c21e8 to
ccd7514
Compare
Contributor
Author
|
Now clang-format complains about different code... |
Contributor
Author
|
Unless I overlooked, the errors are not related to this PR. |
Collaborator
|
I do not understand why clang-format complains |
lauraser
pushed a commit
to lauraser/QualityControl
that referenced
this pull request
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@njacazio , @noferini , FYI.