[QC-592] A facility to store ROOT objects from files to QCDB#862
Merged
Conversation
This makes it possible to take QAResults.root generated by DPL Analysis Tasks and put it to QCDB.
Barthelemy
approved these changes
Oct 5, 2021
| ("task-name", bpo::value<std::string>(), "Name of the task which the objects belong to. Use / to make directories") // | ||
| ("detector-code", bpo::value<std::string>()->default_value("TST"), "3-letter detector code. Put AOD for analysis tasks") // | ||
| ("validity-start", bpo::value<uint64_t>()->default_value(0), "Start of objects validity in ms since epoch") // | ||
| ("validity-end", bpo::value<uint64_t>()->default_value(0), "End of objects validity in ms since epoch") // |
Collaborator
There was a problem hiding this comment.
do you actually want default values here, in particular 0 ?
Collaborator
Author
There was a problem hiding this comment.
For validity and filters: I don't think there is a good way to retrieve those values from analysis tasks, so I would not bother people too much about it before we can offer a solution.
For run number: indeed we could require an explicitly stated value, I will fix this. If it is multi-run, people should be aware of it and put 0 then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to take QAResults.root generated by DPL Analysis Tasks and put them to QCDB.