Skip to content

TH1 for hEventSize and hBusyTime plots modified to TGraph #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
Oct 6, 2021
Merged

TH1 for hEventSize and hBusyTime plots modified to TGraph #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Modules/HMPID/include/HMPID/HmpidTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// Copyright CERN and copyright holders of ALICE O2. This software is
// distributed under the terms of the GNU General Public License v3 (GPL
// Version 3), copied verbatim in the file "COPYING".
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
// See http://alice-o2.web.cern.ch/license for full licensing information.
// This software is distributed under the terms of the GNU General Public
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
//
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
Expand All @@ -20,6 +21,7 @@
#include "HMPIDReconstruction/HmpidDecoder2.h"

class TH1F;
class TGraph;

using namespace o2::quality_control::core;

Expand Down Expand Up @@ -48,8 +50,8 @@ class HmpidTask final : public TaskInterface
private:
TH1F* hPedestalMean = nullptr;
TH1F* hPedestalSigma = nullptr;
TH1F* hBusyTime = nullptr;
TH1F* hEventSize = nullptr;
TGraph* hBusyTime = nullptr;
TGraph* hEventSize = nullptr;
o2::hmpid::HmpidDecoder2* mDecoder = nullptr;
};

Expand Down
46 changes: 26 additions & 20 deletions Modules/HMPID/src/HmpidTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// Copyright CERN and copyright holders of ALICE O2. This software is
// distributed under the terms of the GNU General Public License v3 (GPL
// Version 3), copied verbatim in the file "COPYING".
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
// See http://alice-o2.web.cern.ch/license for full licensing information.
// This software is distributed under the terms of the GNU General Public
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
//
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
Expand All @@ -15,8 +16,10 @@

#include <TCanvas.h>
#include <TH1.h>
#include <TGraph.h>
#include <TMath.h>
#include <Framework/InputRecord.h>
#include <Framework/InputRecordWalker.h>

#include "QualityControl/QcInfoLogger.h"
//#include "HMPID/HmpidDecodeRawMem.h"
Expand Down Expand Up @@ -65,15 +68,19 @@ void HmpidTask::initialize(o2::framework::InitContext& /*ctx*/)
hPedestalSigma->SetXTitle("Pedestal sigma (ADC channel)");
hPedestalMean->SetYTitle("Entries/0.1 ADC");

hBusyTime = new TH1F("hBusyTime", "Average Busy Time", 14, 0, 14);
hBusyTime->SetXTitle("Equipment");
hBusyTime->SetYTitle("Busy time (#mus)");
hBusyTime = new TGraph(14);
hBusyTime->SetName("hBusyTime");
hBusyTime->SetMarkerStyle(20);
hBusyTime->SetLineWidth(0);
hBusyTime->GetXaxis()->SetTitle("Equipment");
hBusyTime->GetYaxis()->SetTitle("Busy time (#mus)");

hEventSize = new TH1F("hEventSize", "Average Event Size", 14, 0, 14);
hEventSize->SetXTitle("Equipment");
hEventSize->SetYTitle("Event size (kB)");
hEventSize = new TGraph(14);
hEventSize->SetName("hEventSize");
hEventSize->SetMarkerStyle(20);
hEventSize->SetLineWidth(0);
hEventSize->GetXaxis()->SetTitle("Equipment");
hEventSize->GetYaxis()->SetTitle("Event size (kB)");

getObjectsManager()->startPublishing(hPedestalMean);
getObjectsManager()->addMetadata(hPedestalMean->GetName(), "custom", "34");
Expand All @@ -93,8 +100,6 @@ void HmpidTask::startOfActivity(Activity& /*activity*/)
ILOG(Info) << "startOfActivity" << ENDM;
hPedestalMean->Reset();
hPedestalSigma->Reset();
hBusyTime->Reset();
hEventSize->Reset();

mDecoder = new o2::hmpid::HmpidDecoder2(14);
mDecoder->init();
Expand All @@ -112,7 +117,8 @@ void HmpidTask::monitorData(o2::framework::ProcessingContext& ctx)
mDecoder->init();
mDecoder->setVerbosity(2); // this is for Debug

for (auto&& input : ctx.inputs()) {
//for (auto&& input : ctx.inputs()) {
for (auto&& input : o2::framework::InputRecordWalker(ctx.inputs())) {
// get message header
if (input.header != nullptr && input.payload != nullptr) {
const auto* header = header::get<header::DataHeader*>(input.header);
Expand All @@ -125,16 +131,16 @@ void HmpidTask::monitorData(o2::framework::ProcessingContext& ctx)
if (!mDecoder->decodeBufferFast()) {
ILOG(Error) << "Error decoding the Superpage !" << ENDM;
}

// Double_t ddl[14], EventSize[14], BusyTime[14];

for (Int_t eq = 0; eq < 14; eq++) {
if (mDecoder->getAverageEventSize(eq) > 0.) {
hEventSize->SetBinContent(eq + 1, mDecoder->getAverageEventSize(eq) / 1000.);
hEventSize->SetBinError(eq + 1, 0.0000001);
hEventSize->AddPoint(eq + 1, mDecoder->getAverageEventSize(eq) / 1000.);
}
if (mDecoder->getAverageBusyTime(eq) > 0.) {
hBusyTime->SetBinContent(eq + 1, mDecoder->getAverageBusyTime(eq) * 1000000);
hBusyTime->SetBinError(eq + 1, 0.00000001);
hBusyTime->AddPoint(eq + 1, mDecoder->getAverageBusyTime(eq) * 1000000);
}
Printf("eq = %i, size = %f, busy = %f", eq, mDecoder->getAverageEventSize(eq), mDecoder->getAverageBusyTime(eq));
for (Int_t column = 0; column < 24; column++) {
for (Int_t dilogic = 0; dilogic < 10; dilogic++) {
for (Int_t channel = 0; channel < 48; channel++) {
Expand Down Expand Up @@ -185,8 +191,8 @@ void HmpidTask::reset()
ILOG(Info) << "Resetting the histogram" << ENDM;
hPedestalMean->Reset();
hPedestalSigma->Reset();
hBusyTime->Reset();
hEventSize->Reset();
hBusyTime->ResetAttFill();
hEventSize->ResetAttFill();
Copy link
Copy Markdown
Collaborator

@Barthelemy Barthelemy Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that is not what you want to do. From the doc:

Reset this fill attributes to default values.

Do I go ahead and merge that ?

Copy link
Copy Markdown
Contributor Author

@gvolpe79 gvolpe79 Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right I just forgot to cancel those lines!

}

} // namespace o2::quality_control_modules::hmpid