FT0/FV0: Add BcOrbitMap for each PM module in DigitQcTask#883
Merged
Conversation
jotwinow
reviewed
Oct 8, 2021
Contributor
jotwinow
left a comment
jotwinow
left a comment
There was a problem hiding this comment.
@Barthelemy @knopers8 We would appreciate it it can still go to the release for the pilot beam. These are important check for the FIT FEE which we need to perform. Thanks for the understanding.
Collaborator
|
@jotwinow This is not up to us. The QC version has been released on Wed and it will be released at P2 along with the FLP Suite on Monday. We will have then to go discuss with RC to ask for a patch release. I'll keep you informed. |
Barthelemy
approved these changes
Oct 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If still possible we would love to have this on our FLP for pilot beams.
We discovered the need for these plots during yesterday tests.