[QC-668] Tune down modules logging.#896
Merged
Barthelemy merged 2 commits intoOct 13, 2021
Merged
Conversation
The modules, and in particular the monitorData method, must specify severity and level for their logs.
Barthelemy
requested review from
knopers8,
mfasDa,
njacazio and
wiechula
as code owners
Collaborator
Author
Collaborator
Author
|
@ktf which version of clang-format do we use in this check ? I obtain a very different format on my mac with v13. |
Member
|
Most likely v12. |
Contributor
|
Ok for me. |
Collaborator
Author
|
@ktf, ok , I have used 11 and it should be ok for the format |
Contributor
|
fine with me. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modules, and in particular the monitorData method, must specify severity and level for their logs.
It is important to allow the proper filtering, at the source or not, of the logs.
@mfasDa
@afurs
@aferrero2707
@JianLIUhep
@wiechula
Could you check my changes ?