TOF: extend digit QC#904
Conversation
njacazio
commented
Oct 13, 2021
njacazio
commented
- Extend configuration of checks/tasks
- Use standard types
- Improve performance
- Use std::make_shared
- Using default destructor in TaskDigits
- Add running mode for TaskDigits
- Simplified RawMultiplicity checker
- Improve messages for shifter
- Update TOF jsons
|
This goes with AliceO2Group/AliceO2#7301 for the memory leak fix |
|
@ercolessi please have a look |
njacazio
force-pushed
the
nj-memleak
branch
2 times, most recently
from
f1cb7a7 to
8fbd07c
Compare
| namespace o2::quality_control_modules::tof | ||
| { | ||
|
|
||
| struct MessagePad { |
njacazio
force-pushed
the
nj-memleak
branch
2 times, most recently
from
c74dfab to
4c952b1
Compare
- Extend configuration of checks/tasks - Use standard types - Improve performance - Use std::make_shared - Using default destructor in TaskDigits - Add running mode for TaskDigits - Simplified RawMultiplicity checker - Improve messages for shifter - Update TOF jsons - Set default drawing style - Customize ToT histogram - Add configurable message pad class - Add default colors based on quality
|
@Barthelemy @knopers8 we are ready to have this reviewed and merged! Suggestions are as always more than welcome, note that I added a class to have a message pad in the QCG, maybe this could be a framework feature instead of a TOF one. |
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
Very nice. Indeed the MessagePad could be moved to the Framework. Do not hesitate to propose a PR if you want. I can also do it.
See my comments for the rest.
| msg->AddText("Default message for hDiagnostic"); | ||
| msg->SetName(Form("%s_msg", mo->GetName())); | ||
|
|
||
| TPaveText* msg = mShifterMessages.MakeMessagePad(h, checkResult); |
There was a problem hiding this comment.
I think that there is a memory leak here. msg is not deleted.
There was a problem hiding this comment.
But the object is added to the list of the monitoring, I think it is then deleted when the MO is deleted, or this is how it should be
|
@Barthelemy your comments should be included in the version of the code, what do you think of them? |
* TOF: extend digit QC - Extend configuration of checks/tasks - Use standard types - Improve performance - Use std::make_shared - Using default destructor in TaskDigits - Add running mode for TaskDigits - Simplified RawMultiplicity checker - Improve messages for shifter - Update TOF jsons - Set default drawing style - Customize ToT histogram - Add configurable message pad class - Add default colors based on quality * Configure -> configure * Use smart pointer
3 participants
