Skip to content

[QC-682] override stop() but do not register a callback #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 2 commits into from
Oct 21, 2021
Merged

[QC-682] override stop() but do not register a callback #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86ffaf2
[QC-682] override stop() but do not register a callback
Barthelemy Oct 21, 2021
73f434d
Put back the callback
Barthelemy Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Framework/include/QualityControl/AggregatorRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ class AggregatorRunner : public framework::Task
/// \brief Callback for CallbackService::Id::Start (DPL) a.k.a. RUN transition (FairMQ)
void start(const framework::ServiceRegistry& services);
/// \brief Callback for CallbackService::Id::Stop (DPL) a.k.a. STOP transition (FairMQ)
void stop();
void stop() override;
/// \brief Callback for CallbackService::Id::Reset (DPL) a.k.a. RESET DEVICE transition (FairMQ)
void reset();

Expand Down
2 changes: 1 addition & 1 deletion Framework/include/QualityControl/CheckRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ class CheckRunner : public framework::Task
/// \brief Callback for CallbackService::Id::Start (DPL) a.k.a. RUN transition (FairMQ)
void start(const framework::ServiceRegistry& services);
/// \brief Callback for CallbackService::Id::Stop (DPL) a.k.a. STOP transition (FairMQ)
void stop();
void stop() override;
/// \brief Callback for CallbackService::Id::Reset (DPL) a.k.a. RESET DEVICE transition (FairMQ)
void reset();

Expand Down
2 changes: 1 addition & 1 deletion Framework/include/QualityControl/PostProcessingDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class PostProcessingDevice : public framework::Task
/// \brief Callback for CallbackService::Id::Start (DPL) a.k.a. RUN transition (FairMQ)
void start();
/// \brief Callback for CallbackService::Id::Stop (DPL) a.k.a. STOP transition (FairMQ)
void stop();
void stop() override;
/// \brief Callback for CallbackService::Id::Reset (DPL) a.k.a. RESET DEVICE transition (FairMQ)
void reset();

Expand Down
2 changes: 1 addition & 1 deletion Framework/include/QualityControl/TaskRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class TaskRunner : public framework::Task
/// \brief Callback for CallbackService::Id::Start (DPL) a.k.a. RUN transition (FairMQ)
void start(const framework::ServiceRegistry& services);
/// \brief Callback for CallbackService::Id::Stop (DPL) a.k.a. STOP transition (FairMQ)
void stop();
void stop() override;
/// \brief Callback for CallbackService::Id::Reset (DPL) a.k.a. RESET DEVICE transition (FairMQ)
void reset();

Expand Down
2 changes: 1 addition & 1 deletion Framework/src/AggregatorRunner.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ void AggregatorRunner::init(framework::InitContext& iCtx)
try {
// registering state machine callbacks
iCtx.services().get<CallbackService>().set(CallbackService::Id::Start, [this, &services = iCtx.services()]() { start(services); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Reset, [this]() { reset(); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });
} catch (o2::framework::RuntimeErrorRef& ref) {
ILOG(Error) << "Error during initialization: " << o2::framework::error_from_ref(ref).what << ENDM;
}
Expand Down
2 changes: 1 addition & 1 deletion Framework/src/CheckRunner.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ void CheckRunner::init(framework::InitContext& iCtx)

// registering state machine callbacks
iCtx.services().get<CallbackService>().set(CallbackService::Id::Start, [this, &services = iCtx.services()]() { start(services); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Reset, [this]() { reset(); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });

for (auto& check : mChecks) {
check.init();
Expand Down
2 changes: 1 addition & 1 deletion Framework/src/PostProcessingDevice.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ void PostProcessingDevice::init(framework::InitContext& ctx)

// registering state machine callbacks
ctx.services().get<CallbackService>().set(CallbackService::Id::Start, [this]() { start(); });
ctx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });
ctx.services().get<CallbackService>().set(CallbackService::Id::Reset, [this]() { reset(); });
ctx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });
}

void PostProcessingDevice::run(framework::ProcessingContext& ctx)
Expand Down
2 changes: 1 addition & 1 deletion Framework/src/TaskRunner.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ void TaskRunner::init(InitContext& iCtx)

// registering state machine callbacks
iCtx.services().get<CallbackService>().set(CallbackService::Id::Start, [this, &services = iCtx.services()]() { start(services); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Reset, [this]() { reset(); });
iCtx.services().get<CallbackService>().set(CallbackService::Id::Stop, [this]() { stop(); });

// setup monitoring
mCollector = MonitoringFactory::Get(mTaskConfig.monitoringUrl);
Expand Down