Trend laser calibration from QCG by cimordas · Pull Request #926 · AliceO2Group/QualityControl

cimordas · 2021-10-22T13:58:43Z

This draft depends on this PR to be finalized and tested with clang

Barthelemy · 2021-11-02T08:29:36Z

+        "url": "infologger:///debug?qc"
+      },
+      "consul": {
+        "url": "http://consul-test.cern.ch:8500"


We used to have this url everywhere but it spams the DNS for no useful reason. Could you just use an empty url ?
Thank you

I changed the url to an empty string "". Is this right?

yes that's good

wiechula

A bit ugly, but ok for the moment I think. Actually, it would be nice if the framework would allow for using any type in the trending tree which has a ROOT dictionary, not only basic types.

Barthelemy · 2021-11-02T10:56:58Z

@wiechula Do not hesitate to create a ticket in JIRA, we consider all requests !

alibuild · 2021-11-02T19:38:09Z

Error while checking build/QualityControl/o2 for cd56afc at 2021-11-02 20:38:

sw/BUILD/O2-latest/log
      Start  98: test_Framework_test_SimpleStatefulProcessing01
84/98 Test  #98: test_Framework_test_SimpleStatefulProcessing01 ........   Passed    0.68 sec
      Start  99: test_Framework_test_SimpleStringProcessing
85/98 Test  #99: test_Framework_test_SimpleStringProcessing ............   Passed    0.56 sec
      Start 100: test_Framework_test_SimpleTimer
86/98 Test #100: test_Framework_test_SimpleTimer .......................   Passed    1.50 sec
      Start 101: test_Framework_test_SimpleWildcard
87/98 Test #101: test_Framework_test_SimpleWildcard ....................   Passed    1.70 sec
      Start 102: test_Framework_test_SimpleWildcard02
88/98 Test #102: test_Framework_test_SimpleWildcard02 ..................   Passed    1.50 sec
      Start 103: test_Framework_test_SingleDataSource
89/98 Test #103: test_Framework_test_SingleDataSource ..................   Passed    1.53 sec
      Start 104: test_Framework_test_Task
90/98 Test #104: test_Framework_test_Task ..............................   Passed    0.62 sec
      Start 105: test_Framework_test_ExternalFairMQDeviceWorkflow
91/98 Test #105: test_Framework_test_ExternalFairMQDeviceWorkflow ......   Passed    2.29 sec
      Start 106: test_Framework_test_VariablePayloadSequenceWorkflow
92/98 Test #106: test_Framework_test_VariablePayloadSequenceWorkflow ...   Passed    1.29 sec
      Start 107: test_Framework_test_ProcessorOptions
93/98 Test #107: test_Framework_test_ProcessorOptions ..................   Passed    0.68 sec
      Start 116: test_Framework_benchmark_RawParser
94/98 Test #116: test_Framework_benchmark_RawParser ....................   Passed   12.78 sec
      Start 117: test_Framework_benchmark_DPLRawPageSequencer
95/98 Test #117: test_Framework_benchmark_DPLRawPageSequencer ..........   Passed    6.69 sec
      Start 118: test_Framework_test_CustomGUIGL
96/98 Test #118: test_Framework_test_CustomGUIGL .......................***Not Run (Disabled)   0.00 sec
      Start 119: test_Framework_test_CustomGUISokol
97/98 Test #119: test_Framework_test_CustomGUISokol ....................***Not Run (Disabled)   0.00 sec
      Start 120: test_Framework_test_SimpleTracksED
98/98 Test #120: test_Framework_test_SimpleTracksED ....................***Not Run (Disabled)   0.00 sec

100% tests passed, 0 tests failed out of 93

Label Time Summary:
benchmark    =  19.47 sec*proc (2 tests)
dplutils     =  19.47 sec*proc (2 tests)
framework    =  52.49 sec*proc (89 tests)
workflow     =  36.34 sec*proc (26 tests)

Total Test time (real) =  72.14 sec

The following tests did not run:
	 85 - test_Framework_test_BoostSerializedProcessing (Disabled)
	 88 - test_Framework_test_DanglingInputs (Disabled)
	118 - test_Framework_test_CustomGUIGL (Disabled)
	119 - test_Framework_test_CustomGUISokol (Disabled)
	120 - test_Framework_test_SimpleTracksED (Disabled)
+ set +x
+ [[ ! -n '' ]]

Full log here.

alibuild · 2021-11-02T22:58:49Z

Error while checking build/QualityControl/o2-cs8 for cd56afc at 2021-11-02 23:58:

sw/BUILD/O2-latest/log
      Start  98: test_Framework_test_SimpleStatefulProcessing01
84/98 Test  #98: test_Framework_test_SimpleStatefulProcessing01 ........   Passed    0.49 sec
      Start  99: test_Framework_test_SimpleStringProcessing
85/98 Test  #99: test_Framework_test_SimpleStringProcessing ............   Passed    0.73 sec
      Start 100: test_Framework_test_SimpleTimer
86/98 Test #100: test_Framework_test_SimpleTimer .......................   Passed    1.58 sec
      Start 101: test_Framework_test_SimpleWildcard
87/98 Test #101: test_Framework_test_SimpleWildcard ....................   Passed    1.88 sec
      Start 102: test_Framework_test_SimpleWildcard02
88/98 Test #102: test_Framework_test_SimpleWildcard02 ..................   Passed    1.76 sec
      Start 103: test_Framework_test_SingleDataSource
89/98 Test #103: test_Framework_test_SingleDataSource ..................   Passed    1.56 sec
      Start 104: test_Framework_test_Task
90/98 Test #104: test_Framework_test_Task ..............................   Passed    0.68 sec
      Start 105: test_Framework_test_ExternalFairMQDeviceWorkflow
91/98 Test #105: test_Framework_test_ExternalFairMQDeviceWorkflow ......   Passed    2.01 sec
      Start 106: test_Framework_test_VariablePayloadSequenceWorkflow
92/98 Test #106: test_Framework_test_VariablePayloadSequenceWorkflow ...   Passed    1.14 sec
      Start 107: test_Framework_test_ProcessorOptions
93/98 Test #107: test_Framework_test_ProcessorOptions ..................   Passed    0.61 sec
      Start 116: test_Framework_benchmark_RawParser
94/98 Test #116: test_Framework_benchmark_RawParser ....................   Passed   12.56 sec
      Start 117: test_Framework_benchmark_DPLRawPageSequencer
95/98 Test #117: test_Framework_benchmark_DPLRawPageSequencer ..........   Passed    7.07 sec
      Start 118: test_Framework_test_CustomGUIGL
96/98 Test #118: test_Framework_test_CustomGUIGL .......................***Not Run (Disabled)   0.00 sec
      Start 119: test_Framework_test_CustomGUISokol
97/98 Test #119: test_Framework_test_CustomGUISokol ....................***Not Run (Disabled)   0.00 sec
      Start 120: test_Framework_test_SimpleTracksED
98/98 Test #120: test_Framework_test_SimpleTracksED ....................***Not Run (Disabled)   0.00 sec

100% tests passed, 0 tests failed out of 93

Label Time Summary:
benchmark    =  19.63 sec*proc (2 tests)
dplutils     =  19.63 sec*proc (2 tests)
framework    =  55.31 sec*proc (89 tests)
workflow     =  37.26 sec*proc (26 tests)

Total Test time (real) =  75.31 sec

The following tests did not run:
	 85 - test_Framework_test_BoostSerializedProcessing (Disabled)
	 88 - test_Framework_test_DanglingInputs (Disabled)
	118 - test_Framework_test_CustomGUIGL (Disabled)
	119 - test_Framework_test_CustomGUISokol (Disabled)
	120 - test_Framework_test_SimpleTracksED (Disabled)
++ set +x
++ [[ ! -n '' ]]

Full log here.

alibuild · 2021-11-03T04:26:37Z

Error while checking build/QualityControl/o2-dataflow-cs8 for cd56afc at 2021-11-03 05:26:

sw/BUILD/O2-latest/log
      Start  98: test_Framework_test_SimpleStatefulProcessing01
84/98 Test  #98: test_Framework_test_SimpleStatefulProcessing01 ........   Passed    0.51 sec
      Start  99: test_Framework_test_SimpleStringProcessing
85/98 Test  #99: test_Framework_test_SimpleStringProcessing ............   Passed    0.64 sec
      Start 100: test_Framework_test_SimpleTimer
86/98 Test #100: test_Framework_test_SimpleTimer .......................   Passed    1.48 sec
      Start 101: test_Framework_test_SimpleWildcard
87/98 Test #101: test_Framework_test_SimpleWildcard ....................   Passed    1.33 sec
      Start 102: test_Framework_test_SimpleWildcard02
88/98 Test #102: test_Framework_test_SimpleWildcard02 ..................   Passed    1.31 sec
      Start 103: test_Framework_test_SingleDataSource
89/98 Test #103: test_Framework_test_SingleDataSource ..................   Passed    1.47 sec
      Start 104: test_Framework_test_Task
90/98 Test #104: test_Framework_test_Task ..............................   Passed    0.52 sec
      Start 105: test_Framework_test_ExternalFairMQDeviceWorkflow
91/98 Test #105: test_Framework_test_ExternalFairMQDeviceWorkflow ......   Passed    1.85 sec
      Start 106: test_Framework_test_VariablePayloadSequenceWorkflow
92/98 Test #106: test_Framework_test_VariablePayloadSequenceWorkflow ...   Passed    1.05 sec
      Start 107: test_Framework_test_ProcessorOptions
93/98 Test #107: test_Framework_test_ProcessorOptions ..................   Passed    0.65 sec
      Start 116: test_Framework_benchmark_RawParser
94/98 Test #116: test_Framework_benchmark_RawParser ....................   Passed   12.75 sec
      Start 117: test_Framework_benchmark_DPLRawPageSequencer
95/98 Test #117: test_Framework_benchmark_DPLRawPageSequencer ..........   Passed    7.48 sec
      Start 118: test_Framework_test_CustomGUIGL
96/98 Test #118: test_Framework_test_CustomGUIGL .......................***Not Run (Disabled)   0.00 sec
      Start 119: test_Framework_test_CustomGUISokol
97/98 Test #119: test_Framework_test_CustomGUISokol ....................***Not Run (Disabled)   0.00 sec
      Start 120: test_Framework_test_SimpleTracksED
98/98 Test #120: test_Framework_test_SimpleTracksED ....................***Not Run (Disabled)   0.00 sec

100% tests passed, 0 tests failed out of 93

Label Time Summary:
benchmark    =  20.23 sec*proc (2 tests)
dplutils     =  20.23 sec*proc (2 tests)
framework    =  48.80 sec*proc (89 tests)
workflow     =  34.27 sec*proc (26 tests)

Total Test time (real) =  69.18 sec

The following tests did not run:
	 85 - test_Framework_test_BoostSerializedProcessing (Disabled)
	 88 - test_Framework_test_DanglingInputs (Disabled)
	118 - test_Framework_test_CustomGUIGL (Disabled)
	119 - test_Framework_test_CustomGUISokol (Disabled)
	120 - test_Framework_test_SimpleTracksED (Disabled)
+ set +x
+ [[ ! -n '' ]]

Full log here.

cimordas added 2 commits October 15, 2021 15:26

First commit of reductor for laser calibration

fa096e9

Trending of the laser calibration from the QCG

9f2a30b

cimordas force-pushed the trend_laserTracks branch from a36d0cd to 9f2a30b Compare November 2, 2021 07:04

Clang-formatting of the laser calibration trending

5307620

cimordas marked this pull request as ready for review November 2, 2021 07:26

cimordas requested review from Barthelemy, knopers8 and wiechula as code owners November 2, 2021 07:26

cimordas changed the title ~~[WIP] Trend laser tracks~~ Trend laser calibration from QCG Nov 2, 2021

Barthelemy reviewed Nov 2, 2021

View reviewed changes

Set consul url to empty

66f9b7a

cimordas force-pushed the trend_laserTracks branch from 52d5507 to 66f9b7a Compare November 2, 2021 08:41

wiechula approved these changes Nov 2, 2021

View reviewed changes

Comment thread Modules/Common/include/Common/TH1Reductor.h Outdated

cimordas and others added 2 commits November 2, 2021 10:56

Revert changes in comment

3607f8c

Merge branch 'master' into trend_laserTracks

cd56afc

Barthelemy merged commit e08c16f into AliceO2Group:master Nov 3, 2021

cimordas deleted the trend_laserTracks branch November 4, 2021 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trend laser calibration from QCG#926

Trend laser calibration from QCG#926
Barthelemy merged 6 commits into
AliceO2Group:masterfrom
cimordas:trend_laserTracks

cimordas commented Oct 22, 2021

Uh oh!

Barthelemy Nov 2, 2021

Uh oh!

cimordas Nov 2, 2021

Uh oh!

Barthelemy Nov 2, 2021

Uh oh!

wiechula left a comment

Uh oh!

Uh oh!

Barthelemy commented Nov 2, 2021

Uh oh!

alibuild commented Nov 2, 2021

Uh oh!

alibuild commented Nov 2, 2021

Uh oh!

alibuild commented Nov 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

cimordas commented Oct 22, 2021

Uh oh!

Barthelemy Nov 2, 2021

Choose a reason for hiding this comment

Uh oh!

cimordas Nov 2, 2021

Choose a reason for hiding this comment

Uh oh!

Barthelemy Nov 2, 2021

Choose a reason for hiding this comment

Uh oh!

wiechula left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Barthelemy commented Nov 2, 2021

Uh oh!

alibuild commented Nov 2, 2021

Uh oh!

alibuild commented Nov 2, 2021

Uh oh!

alibuild commented Nov 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants