Json with mc for ITSTPCmatching#929
Merged
Merged
Conversation
Adding json using MC for ITSTPCmatchingQC fix inputs fix JSON clang-format
chiarazampolli
requested review from
Barthelemy,
knopers8 and
njacazio
as code owners
Contributor
Author
|
cs8 failure is not related to this PR. |
Barthelemy
approved these changes
Oct 26, 2021
Barthelemy
requested changes
Oct 26, 2021
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
There seems to be a genuine bug
chiarazampolli
changed the title
Contributor
Author
|
Hello @Barthelemy , You are right, it needs the other PR in O2: Chiara |
Collaborator
|
Hi @chiarazampolli |
chiarazampolli
changed the title
Contributor
Author
|
Yes, please, I had forgotten about this. |
Barthelemy
approved these changes
Aug 12, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@shahor02 , FYI