Skip to content

Cycle must be 10 seconds minimum#937

Merged
Barthelemy merged 3 commits into
AliceO2Group:masterfrom
Barthelemy:minimum-cycle-duration
Nov 4, 2021
Merged

Cycle must be 10 seconds minimum#937
Barthelemy merged 3 commits into
AliceO2Group:masterfrom
Barthelemy:minimum-cycle-duration

Conversation

@Barthelemy
Copy link
Copy Markdown
Collaborator

@Barthelemy Barthelemy commented Nov 2, 2021

No description provided.

@Barthelemy Barthelemy requested a review from knopers8 as a code owner November 2, 2021 15:04
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Nov 2, 2021

Error while checking build/QualityControl/o2-dataflow-cs8 for ef6b12a at 2021-11-02 20:40:

sw/BUILD/O2-latest/log
      Start  98: test_Framework_test_SimpleStatefulProcessing01
84/98 Test  #98: test_Framework_test_SimpleStatefulProcessing01 ........   Passed    0.83 sec
      Start  99: test_Framework_test_SimpleStringProcessing
85/98 Test  #99: test_Framework_test_SimpleStringProcessing ............   Passed    0.82 sec
      Start 100: test_Framework_test_SimpleTimer
86/98 Test #100: test_Framework_test_SimpleTimer .......................   Passed    1.54 sec
      Start 101: test_Framework_test_SimpleWildcard
87/98 Test #101: test_Framework_test_SimpleWildcard ....................   Passed    1.62 sec
      Start 102: test_Framework_test_SimpleWildcard02
88/98 Test #102: test_Framework_test_SimpleWildcard02 ..................   Passed    1.55 sec
      Start 103: test_Framework_test_SingleDataSource
89/98 Test #103: test_Framework_test_SingleDataSource ..................   Passed    1.71 sec
      Start 104: test_Framework_test_Task
90/98 Test #104: test_Framework_test_Task ..............................   Passed    0.73 sec
      Start 105: test_Framework_test_ExternalFairMQDeviceWorkflow
91/98 Test #105: test_Framework_test_ExternalFairMQDeviceWorkflow ......   Passed    2.13 sec
      Start 106: test_Framework_test_VariablePayloadSequenceWorkflow
92/98 Test #106: test_Framework_test_VariablePayloadSequenceWorkflow ...   Passed    1.29 sec
      Start 107: test_Framework_test_ProcessorOptions
93/98 Test #107: test_Framework_test_ProcessorOptions ..................   Passed    0.73 sec
      Start 116: test_Framework_benchmark_RawParser
94/98 Test #116: test_Framework_benchmark_RawParser ....................   Passed   13.06 sec
      Start 117: test_Framework_benchmark_DPLRawPageSequencer
95/98 Test #117: test_Framework_benchmark_DPLRawPageSequencer ..........   Passed    8.17 sec
      Start 118: test_Framework_test_CustomGUIGL
96/98 Test #118: test_Framework_test_CustomGUIGL .......................***Not Run (Disabled)   0.00 sec
      Start 119: test_Framework_test_CustomGUISokol
97/98 Test #119: test_Framework_test_CustomGUISokol ....................***Not Run (Disabled)   0.00 sec
      Start 120: test_Framework_test_SimpleTracksED
98/98 Test #120: test_Framework_test_SimpleTracksED ....................***Not Run (Disabled)   0.00 sec

100% tests passed, 0 tests failed out of 93

Label Time Summary:
benchmark    =  21.23 sec*proc (2 tests)
dplutils     =  21.23 sec*proc (2 tests)
framework    =  57.21 sec*proc (89 tests)
workflow     =  38.35 sec*proc (26 tests)

Total Test time (real) =  78.68 sec

The following tests did not run:
	 85 - test_Framework_test_BoostSerializedProcessing (Disabled)
	 88 - test_Framework_test_DanglingInputs (Disabled)
	118 - test_Framework_test_CustomGUIGL (Disabled)
	119 - test_Framework_test_CustomGUISokol (Disabled)
	120 - test_Framework_test_SimpleTracksED (Disabled)
+ set +x
+ [[ ! -n '' ]]

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Nov 3, 2021

Error while checking build/QualityControl/o2-cs8 for ef6b12a at 2021-11-03 01:45:

sw/BUILD/O2-latest/log
      Start  98: test_Framework_test_SimpleStatefulProcessing01
84/98 Test  #98: test_Framework_test_SimpleStatefulProcessing01 ........   Passed    0.56 sec
      Start  99: test_Framework_test_SimpleStringProcessing
85/98 Test  #99: test_Framework_test_SimpleStringProcessing ............   Passed    0.55 sec
      Start 100: test_Framework_test_SimpleTimer
86/98 Test #100: test_Framework_test_SimpleTimer .......................   Passed    1.50 sec
      Start 101: test_Framework_test_SimpleWildcard
87/98 Test #101: test_Framework_test_SimpleWildcard ....................   Passed    1.73 sec
      Start 102: test_Framework_test_SimpleWildcard02
88/98 Test #102: test_Framework_test_SimpleWildcard02 ..................   Passed    1.69 sec
      Start 103: test_Framework_test_SingleDataSource
89/98 Test #103: test_Framework_test_SingleDataSource ..................   Passed    1.53 sec
      Start 104: test_Framework_test_Task
90/98 Test #104: test_Framework_test_Task ..............................   Passed    0.73 sec
      Start 105: test_Framework_test_ExternalFairMQDeviceWorkflow
91/98 Test #105: test_Framework_test_ExternalFairMQDeviceWorkflow ......   Passed    2.18 sec
      Start 106: test_Framework_test_VariablePayloadSequenceWorkflow
92/98 Test #106: test_Framework_test_VariablePayloadSequenceWorkflow ...   Passed    1.14 sec
      Start 107: test_Framework_test_ProcessorOptions
93/98 Test #107: test_Framework_test_ProcessorOptions ..................   Passed    0.75 sec
      Start 116: test_Framework_benchmark_RawParser
94/98 Test #116: test_Framework_benchmark_RawParser ....................   Passed   12.47 sec
      Start 117: test_Framework_benchmark_DPLRawPageSequencer
95/98 Test #117: test_Framework_benchmark_DPLRawPageSequencer ..........   Passed    8.25 sec
      Start 118: test_Framework_test_CustomGUIGL
96/98 Test #118: test_Framework_test_CustomGUIGL .......................***Not Run (Disabled)   0.00 sec
      Start 119: test_Framework_test_CustomGUISokol
97/98 Test #119: test_Framework_test_CustomGUISokol ....................***Not Run (Disabled)   0.00 sec
      Start 120: test_Framework_test_SimpleTracksED
98/98 Test #120: test_Framework_test_SimpleTracksED ....................***Not Run (Disabled)   0.00 sec

100% tests passed, 0 tests failed out of 93

Label Time Summary:
benchmark    =  20.71 sec*proc (2 tests)
dplutils     =  20.71 sec*proc (2 tests)
framework    =  56.66 sec*proc (89 tests)
workflow     =  38.24 sec*proc (26 tests)

Total Test time (real) =  77.59 sec

The following tests did not run:
	 85 - test_Framework_test_BoostSerializedProcessing (Disabled)
	 88 - test_Framework_test_DanglingInputs (Disabled)
	118 - test_Framework_test_CustomGUIGL (Disabled)
	119 - test_Framework_test_CustomGUISokol (Disabled)
	120 - test_Framework_test_SimpleTracksED (Disabled)
+ set +x
+ [[ ! -n '' ]]

Full log here.

@knopers8
Copy link
Copy Markdown
Collaborator

knopers8 commented Nov 3, 2021

@Barthelemy Genuine problem with formatting.

knopers8
knopers8 reviewed Nov 3, 2021
View reviewed changes
Comment thread Framework/src/InfrastructureSpecReader.cxx Outdated
Comment on lines +90 to +94
if(ts.cycleDurationSeconds < 10) {
ILOG(Error, Support) << "Cycle duration is too short (" << ts.cycleDurationSeconds << "), replaced by a duration of 10 seconds." << ENDM;
ts.cycleDurationSeconds = 10;
}

Copy link
Copy Markdown
Collaborator

@knopers8 knopers8 Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move validation to TaskRunnerFactory::extractConfig, if we ever move to other sources of defining QC workflows (e.g. by specifying InfrastructureSpec in C++) then the configuration will be still properly validated.

Copy link
Copy Markdown
Collaborator Author

@Barthelemy Barthelemy Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

@Barthelemy Barthelemy enabled auto-merge (squash) November 3, 2021 15:21
@Barthelemy Barthelemy disabled auto-merge November 4, 2021 09:47
@Barthelemy Barthelemy merged commit 50128a6 into AliceO2Group:master Nov 4, 2021
@Barthelemy Barthelemy deleted the minimum-cycle-duration branch November 4, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knopers8 knopers8 knopers8 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Barthelemy @alibuild @knopers8