Skip to content

fix for selection and denominator for efficiency#946

Merged
Barthelemy merged 4 commits into
AliceO2Group:masterfrom
chiarazampolli:fixTOFmatchQC
Nov 9, 2021
Merged

fix for selection and denominator for efficiency#946
Barthelemy merged 4 commits into
AliceO2Group:masterfrom
chiarazampolli:fixTOFmatchQC

Conversation

@chiarazampolli
Copy link
Copy Markdown
Contributor

@noferini , FYI.

@noferini
Copy link
Copy Markdown
Contributor

noferini commented Nov 8, 2021

I would change the default of eta cut to 0.8

diff --git a/Modules/TOF/include/TOF/TOFMatchedTracks.h b/Modules/TOF/include/TOF/TOFMatchedTracks.h
index 3cba08e81e..def7a0192e 100644
--- a/Modules/TOF/include/TOF/TOFMatchedTracks.h
+++ b/Modules/TOF/include/TOF/TOFMatchedTracks.h
@@ -94,7 +94,7 @@ class TOFMatchedTracks final : public TaskInterface

| // for track selection
| float mPtCut = 0.1f;
|
|- float mEtaCut = 1.4f;
| + float mEtaCut = 0.8f;

| int32_t mNTPCClustersCut = 40;
| float mDCACut = 100.f;
| float mDCACutY = 10.f;

@chiarazampolli
Copy link
Copy Markdown
Contributor Author

Ciao @noferini ,

Done!

Chiara

@noferini
Copy link
Copy Markdown
Contributor

noferini commented Nov 8, 2021

if (auto param = mCustomParameters.find("EtaCut"); param != mCustomParameters.end()) {

if (auto param = mCustomParameters.find("etaCut"); param != mCustomParameters.end()) {

"EtaCut" -> "etaCut" otherwise change it in the json

@chiarazampolli
Copy link
Copy Markdown
Contributor Author

Good catch, @noferini !

@noferini
Copy link
Copy Markdown
Contributor

noferini commented Nov 8, 2021

Last comment (I hope)
I can run with "ITS-TPC,TPC" json but not with "ITS-TPC" one.
This because now TPC tracks are used also in the case of global track, then also the TPC only track input is required.
ITS-TPC json should be fixed.

@chiarazampolli
Copy link
Copy Markdown
Contributor Author

Very useful again! Done (I tested it and it worked, but please check as well).

@chiarazampolli
Copy link
Copy Markdown
Contributor Author

Failure on macos seems not related to the PR, @Barthelemy , can you check?

@Barthelemy
Copy link
Copy Markdown
Collaborator

@TimoWilken The macos build is still failing

@chiarazampolli I am force merging

@Barthelemy Barthelemy merged commit c56af1b into AliceO2Group:master Nov 9, 2021
@TimoWilken
Copy link
Copy Markdown
Contributor

@Barthelemy sorry, I missed that the o2 defaults also override the XRootD version. Fixed in alisw/alidist#3537.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants