Skip to content

Always using TPC tracks to fill histograms and bug fix#951

Merged
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
chiarazampolli:fixTrack
Nov 16, 2021
Merged

Always using TPC tracks to fill histograms and bug fix#951
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
chiarazampolli:fixTrack

Conversation

@chiarazampolli
Copy link
Copy Markdown
Contributor

@noferini : I have not yet tested the effect of this change locally, but it should be the correct way to do.

@chiarazampolli
Copy link
Copy Markdown
Contributor Author

Hello @Barthelemy ,

I cannot find the relevant error in the o2 built, and the one for macOS is unrelated. This PR is needed for the async pass, could you take a look?

Thanks!

Chiara

@knopers8
Copy link
Copy Markdown
Collaborator

@ktf @TimoWilken @MichaelLettrich O2 build seems to "successfully fail" while the macOS one fails with:

CMake Error at /System/Volumes/Data/build/ci_checks/alice_ci_0/qualitycontrol-o2/sw/BUILD/f36ce76dfc29bc3106d4625ee1080438dd352065/ROOT/XROOTD-prefix/src/XROOTD-stamp/XROOTD-build-RELWITHDEBINFO.cmake:49 (message):
  Command failed: 2

   '/usr/local/bin/gmake'

  See also

    /System/Volumes/Data/build/ci_checks/alice_ci_0/qualitycontrol-o2/sw/BUILD/f36ce76dfc29bc3106d4625ee1080438dd352065/ROOT/XROOTD-prefix/src/XROOTD-stamp/XROOTD-build-*.log

Could you please have a look?

@chiarazampolli chiarazampolli changed the title Always using TPC tracks to fill histograms [WIP] Always using TPC tracks to fill histograms Nov 15, 2021
@chiarazampolli
Copy link
Copy Markdown
Contributor Author

Please, do not merge yet.

@chiarazampolli chiarazampolli changed the title [WIP] Always using TPC tracks to fill histograms Always using TPC tracks to fill histograms and bug fix Nov 15, 2021
@chiarazampolli
Copy link
Copy Markdown
Contributor Author

PR ready to be merged from my side (if approved).

@chiarazampolli
Copy link
Copy Markdown
Contributor Author

MacOS failure not related, if there is nothing against it, I would ask that the PR is merged to enter the earliest nightly to be then used for the final test before the central async reco.

Chiara

@Barthelemy Barthelemy merged commit 2c64839 into AliceO2Group:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants