Always using TPC tracks to fill histograms and bug fix#951
Merged
Conversation
2d80e11 to
c5cab8a
Compare
Contributor
Author
|
Hello @Barthelemy , I cannot find the relevant error in the o2 built, and the one for macOS is unrelated. This PR is needed for the async pass, could you take a look? Thanks! Chiara |
Collaborator
|
@ktf @TimoWilken @MichaelLettrich O2 build seems to "successfully fail" while the macOS one fails with: Could you please have a look? |
Contributor
Author
|
Please, do not merge yet. |
c5cab8a to
bccbaa8
Compare
Contributor
Author
|
PR ready to be merged from my side (if approved). |
Contributor
Author
|
MacOS failure not related, if there is nothing against it, I would ask that the PR is merged to enter the earliest nightly to be then used for the final test before the central async reco. Chiara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@noferini : I have not yet tested the effect of this change locally, but it should be the correct way to do.