TRD noise removal from plots#956
Merged
Merged
Conversation
Collaborator
|
the test failures seem legit. |
Contributor
Author
|
oui, I am at home sick will get back to this once fully functional. |
bazinski
force-pushed
the
trackletnoiseremoval
branch
from
645e074 to
3628965
Compare
bazinski
force-pushed
the
trackletnoiseremoval
branch
from
3628965 to
f13ab56
Compare
Contributor
Author
|
Hi @Barthelemy |
Collaborator
|
@TimoWilken The two failing tests don't have logs. |
Barthelemy
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the noisy MCMs from the tracklets plots and pulseheight plots.
Keep both the noisy and new plots.
The noisy plots might get removed later.
2 Tasks, pulseheight and tracklettask make connection to ccdbapi, this will of course change later.