Skip to content

[QC-652] Add an executable to update the metadata of an object.#958

Merged
Barthelemy merged 5 commits into
AliceO2Group:masterfrom
Barthelemy:add-bin-update-metadata
Nov 22, 2021
Merged

[QC-652] Add an executable to update the metadata of an object.#958
Barthelemy merged 5 commits into
AliceO2Group:masterfrom
Barthelemy:add-bin-update-metadata

Conversation

@Barthelemy
Copy link
Copy Markdown
Collaborator

@Barthelemy Barthelemy requested a review from knopers8 as a code owner November 18, 2021 14:10
@Barthelemy Barthelemy changed the title [WIP] [QC-652] Add an executable to update the metadata of an object. [QC-652] Add an executable to update the metadata of an object. Nov 22, 2021
Copy link
Copy Markdown
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very nice. I leave a few comments to consider/discuss.

I am wondering how fast it will be to overwrite some key/value for all MOs in a run if the tool is executed for each object separately. I suppose we just have to see. As a room for improvement, we could ask Costin to provide us with a call to overwrite all objects which match path & metadata.

Also, as far as I understand, using this tool will still require us to do some preparatory work before changing anything. Imagine that I want to change a key/value pair for all runs for a specific period and pass. How do I get the list of timestamps or ids to use while invoking the application? Is it something trivial?

Comment thread Framework/src/runMetadataUpdater.cxx
Comment thread Framework/src/runMetadataUpdater.cxx
@Barthelemy
Copy link
Copy Markdown
Collaborator Author

As you noted this tool is still very basic. Selecting objects to update and updating a group of objects is not part of it.

Copy link
Copy Markdown
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Barthelemy Barthelemy merged commit e270756 into AliceO2Group:master Nov 22, 2021
@Barthelemy Barthelemy deleted the add-bin-update-metadata branch November 22, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants