QC offline tracks + clusters task#978
Merged
Merged
Conversation
Collaborator
|
I can revise the PR for what concerns ITS functionalities. |
KotliarovAr
changed the title
Collaborator
|
Hi @KotliarovAr, thank you! Very good piece of work. I think this is fine. One question for @Barthelemy or @knopers8: this PR contains new files, any naming convention of the files or other standards that we should follow? Thanks |
Collaborator
|
Hi, The name of your files seem good. |
Collaborator
|
Thank you, then since the code structure + variable names are taken from ITSClusterTask.cxx and ITSTrackTask.cxx (already in QC since long time), I think you can merge this PR unless you have further comments/suggestions. Thanks! |
KotliarovAr
changed the title
Barthelemy
approved these changes
Dec 10, 2021
Barthelemy
pushed a commit
to Barthelemy/QualityControl
that referenced
this pull request
Jan 13, 2022
* Changed_CMake * Code to run offline task with Cluster Root file * Modified CMake file: add new executable * QC offline tracks + clusters task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task includes two executable files which open and read ROOT files with the TTree objects. Extracted data are distributed to the workflow.